Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added ability to respect the kubebuilder maxlimit #134

Closed
wants to merge 1 commit into from
Closed

added ability to respect the kubebuilder maxlimit #134

wants to merge 1 commit into from

Conversation

swastik959
Copy link

What type of PR is this?

/kind feature
What this PR does / why we need it:
adds the ability to limit of objects to respect the kubebuilder max count
Which issue(s) this PR fixes:

Fixes #124

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swastik959
Once this PR has been reviewed and has the lgtm label, please assign robscott for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @swastik959!

It looks like this is your first PR to kubernetes-sigs/ingress2gateway 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/ingress2gateway has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @swastik959. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 19, 2024
@swastik959
Copy link
Author

hi @levikobi I have tried to create a pr for the feedback if this is what was meant from the issue ?

@LiorLieberman
Copy link
Member

/cc @levikobi

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

levikobi
levikobi reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@levikobi levikobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @swastik959! Thank you for taking on this one.

The maxlimit constant isn't provider-specific limitation. We either need to add this as a common validation to each provider, or (a better approach IMO) check that after the translation already occurred.

Also, please avoid the use of panic.

@LiorLieberman
Copy link
Member

@swastik959 Do you still work on this? Let us know if we can help you to move this forward

@LiorLieberman
Copy link
Member

I am going to close the PR un-assign this now, so others can pick it up. Feel free to reply if you still want to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levikobi levikobi levikobi left review comments

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure generated Gateway-API object fields obey kubebuilder max item validation
4 participants
@swastik959 @k8s-ci-robot @LiorLieberman @levikobi