Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink how to perform merge for GatewayIR on provider specifics. #190

Open
sawsa307 opened this issue Sep 6, 2024 · 2 comments
Open

Rethink how to perform merge for GatewayIR on provider specifics. #190

sawsa307 opened this issue Sep 6, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@sawsa307
Copy link
Contributor

sawsa307 commented Sep 6, 2024

What would you like to be added:
Find a better way to merge GatewayIR. Currently we delegate the merge logic to each provider since the merge only involves provider-specific logic, but there may be an alternative way to make more clean and straightforward.

Why this is needed:
To ensure GatewayIR are merged in a easy-to-read and maintainable manner.

@sawsa307 sawsa307 added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 6, 2024
@sawsa307
Copy link
Contributor Author

sawsa307 commented Sep 6, 2024

/cc @LiorLieberman

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants