From 641920afe1b80ae80ecae523df40c2ea24b9c088 Mon Sep 17 00:00:00 2001
From: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Date: Wed, 11 Sep 2019 21:34:33 +0200
Subject: [PATCH] Minor fixes for the release (#341)

- use tar.gz for installation smoke test on windows
- align manifest template with krew-index
- explicitly enable go modules when building the binaries
---
 docs/RELEASING_KREW.md | 2 +-
 hack/krew.yaml         | 9 +++++++--
 hack/make-binaries.sh  | 2 +-
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/docs/RELEASING_KREW.md b/docs/RELEASING_KREW.md
index 1dec2d89..8ea94eeb 100644
--- a/docs/RELEASING_KREW.md
+++ b/docs/RELEASING_KREW.md
@@ -18,7 +18,7 @@
     KREW_ROOT="$(mktemp -d)" KREW_OS=linux \
         $krew install --manifest=out/krew.yaml --archive=out/krew.tar.gz && \
     KREW_ROOT="$(mktemp -d)" KREW_OS=windows \
-        $krew install --manifest=out/krew.yaml --archive=out/krew.zip
+        $krew install --manifest=out/krew.yaml --archive=out/krew.tar.gz
     ```
 
 ### Release a new version
diff --git a/hack/krew.yaml b/hack/krew.yaml
index 4053ebba..a36d77d8 100644
--- a/hack/krew.yaml
+++ b/hack/krew.yaml
@@ -18,6 +18,7 @@ metadata:
   name: krew
 spec:
   version: "KREW_TAG"
+  homepage: https://sigs.k8s.io/krew
   shortDescription: Package manager for kubectl plugins.
   caveats: |
     krew is now installed! To start using kubectl plugins, you need to add
@@ -30,8 +31,12 @@ spec:
 
       * Windows: Add %USERPROFILE%\.krew\bin to your PATH environment variable
 
-    Run "kubectl krew" to list krew commands and get help.
-    You can find documentation at https://github.com/kubernetes-sigs/krew.
+    To list krew commands and to get help, run:
+      $ kubectl krew
+    For a full list of available plugins, run:
+      $ kubectl krew search
+
+    You can find documentation at https://sigs.k8s.io/krew.
 
   platforms:
   - uri: https://github.com/kubernetes-sigs/krew/releases/download/KREW_TAG/krew.tar.gz
diff --git a/hack/make-binaries.sh b/hack/make-binaries.sh
index 8f97d0db..b39a99af 100755
--- a/hack/make-binaries.sh
+++ b/hack/make-binaries.sh
@@ -37,7 +37,7 @@ git_rev="${SHORT_SHA:-$(git rev-parse --short HEAD)}"
 git_tag="${TAG_NAME:-$(git describe --tags --dirty --always)}"
 echo >&2 "(Stamping with git tag=${git_tag} rev=${git_rev})"
 
-env CGO_ENABLED=0 gox -osarch="${OSARCH:-$supported_platforms}" \
+env GO111MODULE=on CGO_ENABLED=0 gox -osarch="${OSARCH:-$supported_platforms}" \
   -tags netgo \
   -mod readonly \
   -ldflags="-w -X ${version_pkg}.gitCommit=${git_rev} \