From 7da317348c7220f1f76e7ad9cf4ac4a9300151f9 Mon Sep 17 00:00:00 2001
From: Max Gautier <mg@max.gautier.name>
Date: Fri, 13 Dec 2024 20:02:26 +0100
Subject: [PATCH] CI: remove IDEMPOT_CHECK (#11796)

There is no test with IDEMPOT_CHECK=true since commit 7b78e6872 (disable
idempotency tests (#1872), 2017-10-26)

Remove the related infra from our CI scripts.
---
 .gitlab-ci.yml                 |  1 -
 tests/scripts/testcases_run.sh | 23 -----------------------
 2 files changed, 24 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index e2b8864f422..cd49c84932f 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -18,7 +18,6 @@ variables:
   GCE_PREEMPTIBLE: "false"
   ANSIBLE_KEEP_REMOTE_FILES: "1"
   ANSIBLE_CONFIG: ./tests/ansible.cfg
-  IDEMPOT_CHECK: "false"
   RESET_CHECK: "false"
   REMOVE_NODE_CHECK: "false"
   UPGRADE_TEST: "false"
diff --git a/tests/scripts/testcases_run.sh b/tests/scripts/testcases_run.sh
index 87792c23bda..0db5d1788a1 100755
--- a/tests/scripts/testcases_run.sh
+++ b/tests/scripts/testcases_run.sh
@@ -120,29 +120,6 @@ fi
 ## Kubernetes conformance tests
 run_playbook tests/testcases/100_check-k8s-conformance.yml
 
-if [ "${IDEMPOT_CHECK}" = "true" ]; then
-  ## Idempotency checks 1/5 (repeat deployment)
-  run_playbook cluster.yml
-
-  ## Idempotency checks 2/5 (Advanced DNS checks)
-  if [[ ! ( "$CI_JOB_NAME" =~ "hardening" ) ]]; then
-      run_playbook tests/testcases/040_check-network-adv.yml
-  fi
-
-  if [ "${RESET_CHECK}" = "true" ]; then
-    ## Idempotency checks 3/5 (reset deployment)
-    run_playbook reset.yml -e reset_confirmation=yes
-
-    ## Idempotency checks 4/5 (redeploy after reset)
-    run_playbook cluster.yml
-
-    ## Idempotency checks 5/5 (Advanced DNS checks)
-    if [[ ! ( "$CI_JOB_NAME" =~ "hardening" ) ]]; then
-        run_playbook tests/testcases/040_check-network-adv.yml
-    fi
-  fi
-fi
-
 # Test node removal procedure
 if [ "${REMOVE_NODE_CHECK}" = "true" ]; then
   run_playbook remove-node.yml -e skip_confirmation=yes -e node=${REMOVE_NODE_NAME}