Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalizer patch on the pod may overwrite other changes to the finalizer #3899

Open
troychiu opened this issue Dec 20, 2024 · 2 comments · May be fixed by #3912
Open

Finalizer patch on the pod may overwrite other changes to the finalizer #3899

troychiu opened this issue Dec 20, 2024 · 2 comments · May be fixed by #3912
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@troychiu
Copy link
Contributor

What happened:
In our cluster, I noticed that a change to the pod's finalizer was reverted when Kueue attempted to remove its own finalizer. I found we are using non-strict mode patch

return clientutil.Patch(ctx, c, pod, false, func() (bool, error) {
, resulting in the race condition.

What you expected to happen:
Kueue should not overwrite other changes to the finalizer.

How to reproduce it (as minimally and precisely as possible):
Create a pod with finalizers in addition to Kueue's finalizer. However, this issue doesn't always occur.

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Kueue version (use git describe --tags --dirty --always):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@troychiu troychiu added the kind/bug Categorizes issue or PR as related to a bug. label Dec 20, 2024
@mbobrovskyi
Copy link
Contributor

/assign @mykysha

@troychiu
Copy link
Contributor Author

I can create a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants