Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add more meaningful fields to crd objects #210

Open
3 tasks
googs1025 opened this issue Sep 6, 2024 · 10 comments
Open
3 tasks

feature: add more meaningful fields to crd objects #210

googs1025 opened this issue Sep 6, 2024 · 10 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@googs1025
Copy link
Member

googs1025 commented Sep 6, 2024

What would you like to be added:
Currently, when using kubectl get with lws , there are only two fields displayed: name and age. We should provide more meaningful fields to make it more convenient to use.

root@VM-0-8-ubuntu:/home/ubuntu# kubectl get lws
NAME                        AGE
leaderworkerset-sample      5h21m

We should provide more meaningful fields, which will be more convenient to use
as follows:

root@VM-0-8-ubuntu:/home/ubuntu# kubectl get lws
NAME                     READY   UP-TO-DATE   AGE
leaderworkerset-sample   3/3     3            5h21m

There were some minor problems during implementation. FRY: kubernetes-sigs/kubebuilder#4134
I am not sure whether the current JSONPath of kubebuilder can achieve a display effect similar to (X/Y). In addition, should we add other useful fields (maybe we can also discuss this PR)? If not, I will close this issue

Why is this needed:

  • provide more meaningful fields
    Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@googs1025 googs1025 added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 6, 2024
@googs1025
Copy link
Member Author

/assign

@liurupeng
Copy link
Collaborator

@googs1025 Yes, I think adding "READY" and "UP-TO-Update" will be very useful

@googs1025
Copy link
Member Author

That's great, but there's a small problem. kubernetes-sigs/kubebuilder#4134 This problem can be solved by adding an extra field to the status, but I don't think this is a good way to handle it. Maybe we can wait until this problem is solved before implementing it

@googs1025
Copy link
Member Author

issue tracked: kubernetes-sigs/controller-tools#1051

@kerthcet
Copy link
Contributor

Glad to see this aligned with deployment or statefulset which has richer columns.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 12, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Dec 16, 2024

@googs1025 are you still planning to address this issue?

@googs1025
Copy link
Member Author

thanks for reply. @ahg-g
Yes, but there are currently two ways to implement it. 🤔 One is to add a new field in the API to store similar fields. The other method requires the support of upstream k8s, issue link: kubernetes/kubernetes#127246 kep: kubernetes/enhancements#4595

@googs1025
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Dec 23, 2024

thanks for reply. @ahg-g Yes, but there are currently two ways to implement it. 🤔 One is to add a new field in the API to store similar fields. The other method requires the support of upstream k8s, issue link: kubernetes/kubernetes#127246 kep: kubernetes/enhancements#4595

you mean to the status field? can you clarify what fields we need to add?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

6 participants