Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter does not react to its config changes #678

Closed
eero-t opened this issue Sep 6, 2024 · 2 comments
Closed

Adapter does not react to its config changes #678

eero-t opened this issue Sep 6, 2024 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@eero-t
Copy link

eero-t commented Sep 6, 2024

What happened?:

Changed prometheus-adapter (custom metrics configMap) config.

Geneated custom metrics did not change until adapter was restarted (by deleting its pod).

What did you expect to happen?:

Similarly to Prometheus, adapter has config-reloader to handle config changes:

$ kubectl -n monitoring get statefulset/prometheus-prom-kube-prometheus-stack-prometheus -o json | jq .spec.template.spec.containers[].name
"prometheus"
"config-reloader"
$ kubectl -n monitoring get deployment/prom-adapter-prometheus-adapter -o json | jq .spec.template.spec.containers[].name
"prometheus-adapter"

Anything else we need to know?:

Currently handling any automation related to custom metrics is really frustrating. Making that reasonable would require both automatic config reloading, and some prometheus-operator support (prometheus-operator/kube-prometheus#2504).

Environment:

  • prometheus-adapter version: v0.12.0
  • prometheus version: v2.54.0
  • Kubernetes version (use kubectl version): 1.30
@eero-t eero-t added the kind/bug Categorizes issue or PR as related to a bug. label Sep 6, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 6, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If prometheus-adapter contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dgrisonnet
Copy link
Member

It is expected, prometheus-adapter doesn't support automatic config reloading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

3 participants