Adding a clusterID and using on useragent

[rikatz]

What would you like to be added?

Hey folks,

During some debugging with CSI and CAPV, we've figured out some sessions being opened a lot to vCenter and VAPI, and in fact we got some improvements from it.

One thing that was really helpful on CSI side was the fact that they have implemented the clusterID as part of the userAgent, so listing vc sessions (govc session.ls) allowed us to summarize how many connections each cluster/CSI was opening, if the session was stuck, if it was same userAgent and different nodes (some leader election issue?), etc.

I would like to request that we consider the same for vSphere CPI. I couldn't find on the code any reference on setting the clusterID as a config, so I wanted to understand if:

• We can add this extra configuration on yaml config (and make it clear that right now this information is only used for userAgent)
• We can mutate userAgent to, in case clusterID is set, being part of its composition

Thanks

Why is this needed?

Facilitate investigation on VC session leaks, stale connections, add better observation on who/what cluster is consuming connections

[lubronzhan]

Sounds like a good idea. Yeah we don't have any existing clusterID parameter passed. So you can pass it from yaml config or as an arg of command.

[rikatz]

cool, thjanks!
/triage accepted
/assign @rikatz

[k8s-triage-robot]

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

• Confirm that this issue is still relevant with /triage accepted (org members only)
• Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted