-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v3 (2.x) format containerd configuration #49109
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There is a similar change needed a few lines down, for the sandbox image configuration. [plugins."io.containerd.grpc.v1.cri"]
sandbox_image = "registry.k8s.io/pause:3.2" Not sure you want to repeat the "version" for each snippet though, or about the indentation? |
000382c
to
29e4f44
Compare
Good catch! |
Did you see the question about updating the example to the current pause image version? It can be handled as a separate issue, since it affects all runtimes (not only containerd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it feasible to use tabs here?
We prefer tabs when readers have a choice.
29e4f44
to
55f878e
Compare
Hi, @afbjorklund , Now I correct the docker image version from 3.2 to 3.6. |
55f878e
to
ce4b9dd
Compare
ce4b9dd
to
a18ffdd
Compare
It was supposed to be 3.10 Better to do it properly in a separate PR, perhaps Since it affects more than just containerd So you can leave it out in this commit for v2 / v3... |
a18ffdd
to
5040444
Compare
sure. I correct these two back to origin 3.2. |
Description
Add v3 Containerd configuration format
see #48976 (comment)
Issue
Closes: #48976