Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Made Things Easier to Read in Light Mode & Fixed Game Preview Contrast Glitch #2918

Closed
wants to merge 2 commits into from

Conversation

5h0ov
Copy link
Contributor

@5h0ov 5h0ov commented Oct 1, 2023

PR Description 📜

I would like to change the selected areas in the website given below to make it easier to read the text i light mode.
I would also like to fix the game preview images getting a different contrast of colours when switched the light mode.

Preview before fix:

image

Preview Of Changes:

lightgz

Fixes #2917


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

See Above



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Oct 1, 2023

Thank you @5h0ov ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@5h0ov
Copy link
Contributor Author

5h0ov commented Oct 1, 2023

@kunjgit sir could you kindly review this PR under Hacktoberfest '23

@5h0ov 5h0ov changed the title [Enhancement]: Made Things Easier to Read in Light Mode [Enhancement]: Made Things Easier to Read in Light Mode & Fixed Game Preview Contrast Glitch Oct 1, 2023
@kunjgit
Copy link
Owner

kunjgit commented Oct 3, 2023

Hey @5h0ov you need to have significant enhancement to get it merged !
Try to do some more enhancement looking forward to have our next step :octocat:

@5h0ov
Copy link
Contributor Author

5h0ov commented Oct 3, 2023

Hey @5h0ov you need to have significant enhancement to get it merged ! Try to do some more enhancement looking forward to have our next step :octocat:

ok i will see what i can do :)

@5h0ov
Copy link
Contributor Author

5h0ov commented Oct 3, 2023

Hey @5h0ov you need to have significant enhancement to get it merged ! Try to do some more enhancement looking forward to have our next step :octocat:

@kunjgit could you suggest something more to enhance in the website? 😥
or do i enhance the UI/add a new feature of a game as well?

@kunjgit
Copy link
Owner

kunjgit commented Oct 4, 2023

Hey @5h0ov you can do one thing dark mode is too mess so that effect that we have on website you can remove that effect and improve the UI so it will look aesthetic and more attractive ! :octocat:

@5h0ov
Copy link
Contributor Author

5h0ov commented Oct 4, 2023

Hey @5h0ov you can do one thing dark mode is too mess so that effect that we have on website you can remove that effect and improve the UI so it will look aesthetic and more attractive ! :octocat:

You mean this effect sir?:

image

or the floating white particles in background?

@5h0ov
Copy link
Contributor Author

5h0ov commented Oct 6, 2023

@kunjgit Sir, I will try to solve the UI Issue later. For now i am closing this PR. Thanks !

@5h0ov 5h0ov closed this Oct 6, 2023
@kunjgit
Copy link
Owner

kunjgit commented Oct 6, 2023

Thank you @5h0ov , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Making Things Easier to Read in Light Mode
2 participants