From 4a6068edc755cf4cccd218d57ae7e5c6ba095ca3 Mon Sep 17 00:00:00 2001 From: Joy <29514446+fillwithjoy1@users.noreply.github.com> Date: Thu, 16 May 2024 12:48:43 +1000 Subject: [PATCH 1/4] docs: add reference to Claro Paraguay (#275) Co-authored-by: Kyujin Cho --- docs/compatibility-chart.en.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/compatibility-chart.en.md b/docs/compatibility-chart.en.md index ff7c0a5..9977a34 100644 --- a/docs/compatibility-chart.en.md +++ b/docs/compatibility-chart.en.md @@ -41,6 +41,7 @@ Carrier not being listed on the table does not mean that this patch won't work f | Europe | Russia (250) | Beeline Russia (28) | O | X | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/discussions/97) | | Europe | Spain (214) | Orange (03) | O | O | MVNO: spn: JAZZTEL. [Reference](https://github.com/kyujin-cho/pixel-volte-patch/discussions/1#discussioncomment-6869373) | | Europe | Turkey (286) | Turkcell (01) | O | O | May need to register to carrier from other device and `ims` APN. [Reference](https://github.com/kyujin-cho/pixel-volte-patch/discussions/1#discussioncomment-6261820) | +| South America | Paraguay (744) | Claro (05) | O | X | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/discussions/1#discussioncomment-5081642) | Oceania | New Zealand (530) | Spark NZ (05) | O | O | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/discussions/1#discussioncomment-4940003) | | Oceania | Australia (505) | Telstra (01) | O | O | Backup Calling doesn't seem to work (could be a handset issue) [Reference](https://github.com/kyujin-cho/pixel-volte-patch/pull/238) | Oceania | New Zealand (530) | 2degrees NZ (24) | O | X | VoWiFi doesn't seem to work regardless of whether 'ims' APN is present or not. Post June 2023 Security Patch, VoLTE and 5G (NR) seem to be natively enabled now. [Reference](https://github.com/kyujin-cho/pixel-volte-patch/discussions/1#discussioncomment-5644517) | From 737a6050b927e101440aebd2425b86302ad9119f Mon Sep 17 00:00:00 2001 From: Kyujin Cho Date: Thu, 16 May 2024 11:56:47 +0900 Subject: [PATCH 2/4] chore(ci): run `build-debug-apk` only if actual source code has changed --- .github/workflows/build-debug-apk.yml | 43 +++++++++++++++++++++++++++ .github/workflows/default.yml | 30 ------------------- 2 files changed, 43 insertions(+), 30 deletions(-) create mode 100644 .github/workflows/build-debug-apk.yml diff --git a/.github/workflows/build-debug-apk.yml b/.github/workflows/build-debug-apk.yml new file mode 100644 index 0000000..49688b5 --- /dev/null +++ b/.github/workflows/build-debug-apk.yml @@ -0,0 +1,43 @@ +name: default + +on: + push: + paths: + - 'app/src/**' + pull_request: + paths: + - 'app/src/**' +permissions: + pull-requests: write + +jobs: + build-debug-apk: + needs: [lint] + if: github.event_name == 'pull_request' + uses: ./.github/workflows/build-apk.yml + with: + build-type: debug + secrets: + key-alias: ${{ secrets.DEBUG_KEY_ALIAS }} + keystore: ${{ secrets.DEBUG_KEYSTORE_B64 }} + key-password: ${{ secrets.DEBUG_KEY_PASSWORD }} + post-apk-link: + needs: [build-debug-apk] + runs-on: ubuntu-latest + steps: + - name: Post link to action run detail page + uses: actions/github-script@v6 + with: + script: | + try { + const commentResult = await github.rest.issues.createComment({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + body: `APK build completed! Visit [action run detail page](https://github.com/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}) to download the APK to test this pull request.` + }) + console.log(commentResult) + } catch (e) { + console.log("Comment not posted:") + console.log(e) + } diff --git a/.github/workflows/default.yml b/.github/workflows/default.yml index c24f4ab..412c4d0 100644 --- a/.github/workflows/default.yml +++ b/.github/workflows/default.yml @@ -22,36 +22,6 @@ jobs: with: report-path: build/*.xml # Support glob patterns by https://www.npmjs.com/package/@actions/glob continue-on-error: false # If annotations contain error of severity, action-ktlint exit 1. - build-debug-apk: - needs: [lint] - if: github.event_name == 'pull_request' - uses: ./.github/workflows/build-apk.yml - with: - build-type: debug - secrets: - key-alias: ${{ secrets.DEBUG_KEY_ALIAS }} - keystore: ${{ secrets.DEBUG_KEYSTORE_B64 }} - key-password: ${{ secrets.DEBUG_KEY_PASSWORD }} - post-apk-link: - needs: [build-debug-apk] - runs-on: ubuntu-latest - steps: - - name: Post link to action run detail page - uses: actions/github-script@v6 - with: - script: | - try { - const commentResult = await github.rest.issues.createComment({ - issue_number: context.issue.number, - owner: context.repo.owner, - repo: context.repo.repo, - body: `APK build completed! Visit [action run detail page](https://github.com/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}) to download the APK to test this pull request.` - }) - console.log(commentResult) - } catch (e) { - console.log("Comment not posted:") - console.log(e) - } build-release-apk: needs: [lint] if: github.event_name == 'push' && contains(github.ref, 'refs/tags/') From 651b0fc0da9529842a2057d0ee7979e0cc0daa56 Mon Sep 17 00:00:00 2001 From: Joy <29514446+fillwithjoy1@users.noreply.github.com> Date: Thu, 16 May 2024 12:59:14 +1000 Subject: [PATCH 3/4] docs: add france and update orange pl (#254) --- docs/compatibility-chart.en.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/compatibility-chart.en.md b/docs/compatibility-chart.en.md index 9977a34..568861a 100644 --- a/docs/compatibility-chart.en.md +++ b/docs/compatibility-chart.en.md @@ -29,10 +29,11 @@ Carrier not being listed on the table does not mean that this patch won't work f | South America | Peru (716) | Claro (10) | O | X | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/discussions/93) | | Europe | Bulgaria (284) | Yettel (05) | O | Not operational | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/discussions/1#discussioncomment-5012767) | | Europe | Czech Republic (230) | O2 (02) | O | O | Tested on my own Pixel 6a, both VoLTE & VoWiFi work [Reference](https://github.com/kyujin-cho/pixel-volte-patch/pull/130) | +| Europe | France (208) | Bouygues (20, 21) | O | O | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/issues/175) | | Europe | Various countries | Elisa | O | O | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/issues/125#issue-1698533656) | | Europe | Various countries | Saunalahti | O | O | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/issues/125#issue-1698533656) | | Europe | Switzerland (228) | Salt (03) | O | O | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/issues/125#issuecomment-1546696568) | -| Europe | Poland (260) | Orange PL (03) | O | O | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/issues/17) | +| Europe | Poland (260) | Orange PL (03) | O | O | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/issues/17). If Vo-Wifi isn't working, you may need to add the `ims` APN [Reference](https://github.com/kyujin-cho/pixel-volte-patch/issues/136#issuecomment-1565598716) | | Europe | Poland (260) | Plus (01) | O | O | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/issues/17) | | Europe | Poland (260) | Play (06) | O | O | Need to set APN as `ims`. [Reference](https://github.com/kyujin-cho/pixel-volte-patch/issues/17) | | Europe | Romania (226) | Vodafone (01) | O | O | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/discussions/6) | From ef16fb05ddc185609872c8903051b74aa4b74e47 Mon Sep 17 00:00:00 2001 From: Kyujin Cho Date: Thu, 16 May 2024 12:03:16 +0900 Subject: [PATCH 4/4] chore(ci): add lint checker also to `build-debug-apk` action --- .github/workflows/build-debug-apk.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.github/workflows/build-debug-apk.yml b/.github/workflows/build-debug-apk.yml index 49688b5..60c7323 100644 --- a/.github/workflows/build-debug-apk.yml +++ b/.github/workflows/build-debug-apk.yml @@ -11,6 +11,21 @@ permissions: pull-requests: write jobs: + lint: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - name: install ktlint + run: | + curl -sSLO https://github.com/pinterest/ktlint/releases/download/0.48.2/ktlint && chmod a+x ktlint && sudo mv ktlint /usr/local/bin/ + - name: run ktlint + run: | + ktlint --reporter=checkstyle,output=build/ktlint-report.xml + continue-on-error: true + - uses: yutailang0119/action-ktlint@v3 + with: + report-path: build/*.xml # Support glob patterns by https://www.npmjs.com/package/@actions/glob + continue-on-error: false # If annotations contain error of severity, action-ktlint exit 1. build-debug-apk: needs: [lint] if: github.event_name == 'pull_request'