You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Whenever we make small adjustments to our codebase, we may improve type information.
It may be a good idea to reduce our psalm-baseline.xml accordingly, when possible.
The rough idea is that:
a new change is pushed to the main configured branch (to be detected by CI)
the change removed one type error somewhere
we run vendor/bin/psalm --update-baseline, which should reduce the contents of psalm-baseline.xml (if it exists)
if changes are produced by this pipeline, commit them
push these changes to a reserved branch
run CI on that branch
auto-merge to main branch
This is extremely elaborate, compared to our current CI tasks, so it requires a lot of added engineering work around the pipeline, but it can probably be done :-)
The text was updated successfully, but these errors were encountered:
With psalm having the new feature findUnusedBaselineEntry, I'd rather have this being done by the developer who improves types.
Not sure if the CI pipeline is the right place to run code improvements tho. We do require developers to run composer cs-fix, why not add composer baseline-update and let devs run this as well (once we enabled findUnusedBaselineEntry)?
Feature Request
Summary
Whenever we make small adjustments to our codebase, we may improve type information.
It may be a good idea to reduce our
psalm-baseline.xml
accordingly, when possible.The rough idea is that:
vendor/bin/psalm --update-baseline
, which should reduce the contents ofpsalm-baseline.xml
(if it exists)This is extremely elaborate, compared to our current CI tasks, so it requires a lot of added engineering work around the pipeline, but it can probably be done :-)
The text was updated successfully, but these errors were encountered: