-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to specify the search term for a tv show #175
Comments
Hey @JorTurFer, Yeah that certainly makes sense. I'm trying to think of the best way to solve this. I'd like to avoid having users manually editing records. TMDB returns the language-specific results, but it also include the original_name. So, when searching for The Legend of Vox Machina, it returns So, there could just be a checkbox for shows/movies titled "use original title when searching" and then nefarious would use the Would that suffice your use case? Example requesting Spanish results: {
"page": 1,
"results": [{
"backdrop_path": "/lX33BV2g6O2B6PwMtTUSyzGrfq9.jpg",
"first_air_date": "2022-01-27",
"genre_ids": [
16,
10765
],
"id": 135934,
"name": "La leyenda de Vox Machina",
"origin_country": [
"US"
],
"original_language": "en",
"original_name": "The Legend of Vox Machina",
"overview": "Son un hatajo de pendencieros inadaptados reconvertidos en mercenarios. A Vox Machina le interesa más el dinero fácil y la cerveza barata que proteger el reino. Pero cuando este se ve amenazado por algo maligno, esta bulliciosa panda se da cuenta de que nadie más puede restablecer la justicia. Lo que empezó como un día de pago más es ahora la historia del origen de los nuevos héroes de Exandria.",
"popularity": 178.913,
"poster_path": "/4fqfhmVNOHe2nLcligiVMtMnfeM.jpg",
"vote_average": 8.8,
"vote_count": 28
}],
"total_pages": 1,
"total_results": 1
} |
That's perfect for my use case :) |
Great. I don't think this will be a difficult implementation. I'll leave this ticket open until I have time to work on it. |
Thanks!! No rush at all 😄 |
I think I spoke too soon on the difficulty of this task. All the torrent name parsing logic (borrowed from sonarr/radarr) is largely expecting Latin-based languages which is obviously very limiting. In addition, I'm noticing foreign language films (relative to usa) include the original title and the english title which is a separate challenge in parsing out the titles since it includes both. For instance, searching for the movie
|
in that case no worries, thanks for trying it ❤️ |
I think specifying the title manually would have the same challenges. For instance, if you're searching for the original title for |
But you could ignore the current value if another value has been specified. I mean, if I specify |
That's true. Maybe it could be that simple. So, if the search original name option is chosen, we'd just need to strip out any matching translated part. If we're looking for the japanese film
We'd have to remove I'll give this a test and see how well it does. |
Well, shoot. I just tested the current parsing logic in nefarious and it doesn't match anything for the above result, with
Returns None. I'm assuming we'd have to update the parsing logic and I haven't dug into that yet. Maybe it's a non-latinlanguage issue? Parsing logic for movies: |
Let me try during the day using that name with the serie that I say (the legend of vox machina) |
Something like |
Yeah you have the command right. I usually just manually run a search against jackett to find real responses to test with, and then use the title against the command line utility to see how nefarious parses the title. I found out a couple things, most of the parsers expects a year in the title which is why the previous examples weren't working. Secondly, a while ago I added a unicode "transliteration" to ASCII which aimed to successfully match non-original ascii titles produced by indexers. (e.g Here's a quick way to setup your local python environment to be able to run the command line utility: Change to nefarious source directory
Create new python virtual environment (in /tmp)
Install python dependencies:
Parse 1:
Parse 2 without transliteration (just return
Movie Parsers |
So long story short, maybe by disabling transliteration when searching original titles may do the trick. I'll investigate. |
Nefarious monitor the availability of new episodes for the TV shows and this is awesome feature ❤️
The problem is sometimes that in non-English tackers, sometimes the uploaders names the torrents with the Spanish translation and other with the English name. In these cases, it'd be nice if I can override the search term for this specific tv show.
An example,
The Legend of Vox Machina
is translated intoLa leyenda de Vox Machina
. Nefarious try to look forLa leyenda de Vox Machina
but the uploader uploaded all the show using the original name instead of the translated name. For movies this is not a problem because I go manually and select the torrent, but in tv shows, this means that I have to add all the torrents one by one, and I lose also the capability of automatic tracking for new episodes.Thanks for this awesome tool! ❤️ ❤️ ❤️ ❤️
The text was updated successfully, but these errors were encountered: