-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fake-video-detection toggle & false positives #203
Comments
Thanks for bringing this up. It sounds like a bug but i'm trying to find out more. I haven't seen it yet. Can you tell me what the files in the directory were? Redact titles is fine, i'm just curious about file extensions and such. |
I just disabled the video detection until I can fix the issue, and I'll make it a setting so it can be toggled on/off in the future. |
First example was just a text file and the video file. Video file has the following properties: I'm testing with another movie right now to see if I can recreate the issue again while I'm actively watching. |
Movie directory:
ffprobe info:
|
I added the ability to toggle this feature on/off in the settings page (#204) so you can now disable this while we figure out this false/positive issue. It's disabled by default. Would you mind sending me (lardbit at gmail dot com) a link to content (via mega.nz or wherever) that triggered a false positive for you? I can't reproduce the issue by fabricating an identical directory listing (e.g. This will be pushed out in about an hour, once the build is complete. Thanks. |
Great, pinging out of band with examples. |
Thanks for sending those videos. Unfortunately, I wasn't able to reproduce the issue by manually applying the video detection logic to them individually. Did you say you were seeing false/positives for all movies or only some? Would you mind running (something like) the following on a few directories and let me know the output?
Which will output something like:
I just can't reproduce the error yet so I'm trying to understand the differences of our setup. Thanks for the help troubleshooting. |
Well this is fun. When I run the command you specified it find finds a valid video:
but when I remove it and re add it with automatic video detection enabled, it triggers a failure:
So looks like maybe the issue is in the returning the result of the fake-video-detection? |
Well shit...Would you mind sending me the original torrent via email so I can reproduce it on my end? |
Yep, responded out of band. |
Hi, is there a way to disable the fake-video-detection system? It seems to be triggering on my setup for almost every video and it's been a false positive each time:
or if this is not the fake video detection, what's going on here?
The text was updated successfully, but these errors were encountered: