Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password when pairing. #66

Open
jhsa opened this issue Sep 20, 2022 · 3 comments
Open

Password when pairing. #66

jhsa opened this issue Sep 20, 2022 · 3 comments

Comments

@jhsa
Copy link

jhsa commented Sep 20, 2022

I couldn't find anything about requesting a password when pairing the BLE-MIDI with another device, so I guess it could be a legitimate feature request?
The reason for this is that if we don't pair a device immediately when we are on stage, and as it is not protected by a password, anyone from the audience could pair to the ESP32 running the BLE-MIDI library, and together with a midi app on his/her phone, cause a big caos on stage. I think a password is very important to prevent something like that to happen on stage. MIDI is made for musicians, and musicians perform for a lot of people..
Thanks in advance for looking into it.

@lathoub
Copy link
Owner

lathoub commented Oct 22, 2022

That would be a great addition - feel free to add password pairing to this lib and suggest a PR

@jhsa
Copy link
Author

jhsa commented Oct 24, 2022

That would be a great addition - feel free to add password pairing to this lib and suggest a PR

It would be a great addition, for safety reasons, that is why I suggested it. :)
But I don't know how to do it. If I did, I wouldn't need to suggest it, I would have already done it. ;)
Unfortunately, I am still not at your level as far as programming is concerned.
Thanks for this excellent library by the way.

@RobertoHE
Copy link
Contributor

BLE client can accept a user-defined method for setting an authorized pairing by password, ping or whatever in the develop branch https://github.com/RobertoHE/Arduino-BLE-MIDI/tree/CustomSettings (this branch is under pull request yet).
You can add in your main code a configuration Struct (see the example of the branch) and add a custom callback function with your password or whatever you want and you can set the pairing capabilities of your BT device (screen, keyboard, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants