Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build the projects after checkout and following the instructions in README. #169

Open
cpauya opened this issue May 14, 2020 · 1 comment

Comments

@cpauya
Copy link
Contributor

cpauya commented May 14, 2020

Observed behavior

I cannot build these projects after checkout of the repo and following the build steps to Run the project using Inno Setup for development.

  1. Visual Studio project (Kolibri GUI app): \src\gui-source\Kolibri.sln
  2. Inno Setup project (Kolibri installer): \src\installer-source\KolibriSetupScript.iss

Here's a list of the issues. See below for screenshots.

  1. Visual Studio 2015 Community Edition - Issue: Install Windows XP Support for C++ -- Windows 7.1 SDK for targeting Windows XP.
  2. InnoSetup - Issue: build error, some settings are needed in the [Setup] section AppVerName, etc
  3. Inno Setup - Issue: Language files are missing -- Greek.isl, Nepali.isl, Vietnamese.isl, Marathi.islu, Korean.isl, Hindi.islu, Bulgarian.isl, Bengali.islu
  4. Wheel file is missing at the \src\installer-source\kolibri*.whl

Issue: Install Windows XP Support for C++ -- Windows 7.1 SDK for targeting Windows XP.
Screen Shot 2020-05-13 at 2 56 44 PM

Issue: Language files are missing -- Greek.isl, Nepali.isl, Vietnamese.isl, Marathi.islu, Korean.isl, Hindi.islu, Bulgarian.isl, Bengali.islu
Screen Shot 2020-05-13 at 5 49 51 PM

Expected behavior

The repo projects should build after following the instructions in the README.

Possible Solution/s

  1. For the "missing languages" issue, copy the missing files from the \src\inno-compiler\Languages\ folder to the C:\Program Files (x86)\Inno Setup 6\Languages\ folder. Note: needs admin permissions
  2. If no repo changes are needed, maybe update the README file to address the above issues.

User-facing consequences

This hampers development and might discourage outside contributions.

Errors and logs

n/a

Steps to reproduce

  1. Checkout the repo.
  2. Follow the steps to Run the project using Inno Setup for development
  3. Notice the issues that are shown.

Context

  • Operating system: Windows 10
  • branch: develop
@cpauya cpauya changed the title Cannot build the projects after checkout and following the build instructions. Cannot build the projects after checkout and following the instructions in README. May 14, 2020
@indirectlylit
Copy link
Contributor

thanks!

as a stop-gap, I've added a quick note to the readme referencing this issue: 3aa0c60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants