Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open setup wizard in the OS language #200

Open
radinamatic opened this issue Jul 29, 2019 · 6 comments
Open

Open setup wizard in the OS language #200

radinamatic opened this issue Jul 29, 2019 · 6 comments
Labels
TAG: new feature New user-facing feature

Comments

@radinamatic
Copy link
Member

radinamatic commented Jul 29, 2019

Observed behavior

I thought we already had this issue filed at some point, but I'm unable to find it.

Post-install Kolibri setup wizard opens in English irregardless of the user's OS language. Since we advanced the work on the Kolibri default language setup, maybe this could be a good addition. Namely, the setup wizard should open in the default language user has on their OS, and default to English, if their language is not supported by Kolibri.

This should be a cross-platform feature, but maybe in case of the Windows installer, if the user's OS language isn't supported we could set the one selected during the installation?

setup-wizard-language

Expected behavior

Better language-related UX?

User-facing consequences

Less selections during the installation and setup proces?

Errors and logs

Steps to reproduce

Context

cc @indirectlylit @mrpau-dev @benjaoming

@indirectlylit indirectlylit added the TAG: new feature New user-facing feature label Aug 23, 2019
@indirectlylit
Copy link
Contributor

@benjaoming
Copy link
Contributor

I think we can try having the installer define a locale, and then Kolibri could choose this locale in the Setup Wizard if it's a supported language. Should be case insensitive and replace _ with - when matching.

CC: @rtibbles - I think you've already had a look at the ways that language is chosen from HTTP request vs. settings.LANGUAGE_CODE etc..

@rtibbles
Copy link
Member

rtibbles commented Sep 3, 2019

We could currently do this by opening with the language code in the URL (http://127.0.0.1:8080/<lang-code>) - I think this is unlikely to change, so might be a quick and stable way to move forward with this.

@benjaoming
Copy link
Contributor

@rtibbles we would need a way to verify that Kolibri supports <lang> before opening up such a page... or to have the installer match up the platform language for the installer with a list of supported languages.

@rtibbles
Copy link
Member

rtibbles commented Sep 4, 2019

Good point - can check that the URL doesn't return a 404 (which is what it does for unrecognized lang codes).

@benjaoming
Copy link
Contributor

@rtibbles -- good idea. I think that all the installer libraries would have an HTTP library to do a header request to a specific page, check if it's 404 and then default to not setting a language code in the URL path if that's the case.

@rtibbles rtibbles transferred this issue from learningequality/kolibri Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TAG: new feature New user-facing feature
Projects
None yet
Development

No branches or pull requests

4 participants