Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.18 - Select device modal - The device name is not displayed #12896

Open
pcenov opened this issue Nov 29, 2024 · 4 comments
Open

0.18 - Select device modal - The device name is not displayed #12896

pcenov opened this issue Nov 29, 2024 · 4 comments
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) bug Behavior is wrong or broken DEV: frontend P1 - important Priority: High impact on UX TAG: regression Something that previously worked

Comments

@pcenov
Copy link
Member

pcenov commented Nov 29, 2024

Observed behavior

Observed some regressions on that modal, namely the device name is not automatically displayed and there's a scroll-bar:

Image

If I manually add the device, then the device name is shown correctly:

Image

Expected behavior

Correctly displayed device name and no scroll-bar when it's not necessary

Steps to reproduce the issue

  1. Install the build asset from https://github.com/learningequality/kolibri/releases/tag/v0.18.0-alpha0
  2. Attempt to import a facility while going through the Setup Wizard or at Device > Facilities

Usage Details

https://github.com/learningequality/kolibri/releases/tag/v0.18.0-alpha0
Ubuntu 22 - Chrome

@pcenov
Copy link
Member Author

pcenov commented Nov 29, 2024

@radinamatic

@radinamatic radinamatic added bug Behavior is wrong or broken P1 - important Priority: High impact on UX TAG: regression Something that previously worked APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend labels Nov 29, 2024
@JoeCelaster
Copy link

JoeCelaster commented Dec 6, 2024

@radinamatic

@pcenov Please assign me to this issue,
I can work on this for sure.

@MisRob
Copy link
Member

MisRob commented Dec 6, 2024

Hi @JoeCelaster, thanks for volunteering! This issue is not labeled 'help wanted' and therefore not open for contribution.

There are contributing opportunities in several repositories. See the contributing guidelines including links to issues suitable for contribution for each repository here:

You can also see the list of unassigned "help wanted" or "good first issue" issues across all repositories.

@JoeCelaster
Copy link

@MisRob Okay Fine , Thanks for letting me know...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) bug Behavior is wrong or broken DEV: frontend P1 - important Priority: High impact on UX TAG: regression Something that previously worked
Projects
None yet
Development

No branches or pull requests

4 participants