-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of Less for styling in favour of SCSS #4827
Comments
hello @rtibbles can you assign this to me? |
/assign |
Hi @Yadnyesh-More. Thank you! I have assigned it to you. Be sure to reach out to reach out to @rtibbles incase its not clear what needs to be done while resolving the issue. Apologies @chetan21122004. As @Yadnyesh-More requested first, the issue has been assigned to him. I'll be sure to let you know incase it's available again. |
@chetan21122004 We currently have other contributing opportunities in three repositories. You can see the contributing guidelines including links to issues suitable for contribution for each repository here: Kolibri Contributing Guidelines |
@akolson ok I will, Thanks ✨ |
hello @rtibbles Due to some unforeseen reasons, I won’t be able to work on the assigned task at the moment. I kindly request you to unassign it so someone else can take it up and ensure progress. |
Hi @Yadnyesh-More! Thanks for letting us know. No worries :), I will unassign this issue from you. |
Hi @rtibbles @AlexVelezLl , can i work on this issue? |
Hi @adibmbrk, thank you for volunteering! I will assign you. |
Hi @adibmbrk, I wanted to mention that Learning Equality will be closed from December 23 to January 5. |
@adibmbrk Are you still working on this issue? |
hi @shruti862 , yes im working on this issue |
Observed behavior
Studio currently has three vestigial less style files that necessitate us adding additional tooling to handle.
contentcuration/contentcuration/frontend/shared/styles/main.less
contentcuration/contentcuration/frontend/shared/views/MarkdownEditor/plugins/image-upload/style.less
contentcuration/contentcuration/frontend/shared/views/MarkdownEditor/plugins/formulas/style.less
Unfortunately, there are also many more
"less"
style blocks in our Vue.js components that also need to be updated.For the most part of a lot of these are probably SCSS compatible (and some appear to be simply plain CSS), but each would need to be checked and updated.
Expected behavior
Probably the most foolproof procedure for converting each LESS block here will be:
First compile the LESS to CSS (can either use a web tool like https://lesscss.org/less-preview/ or use the LESS cli/API in local development).
Then if there are any obvious ways to use SCSS syntax to cleanup the resulting CSS, this can be applied in a second step.
Once all the files have been converted, then any less related tooling in our build pipeline can be removed, and any less related dependencies removed using
yarn
.The text was updated successfully, but these errors were encountered: