Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hits with no energy deposits in pet_to_stp #44

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

fhagemann
Copy link
Contributor

When reading in GEANT4 files, some hits might not have energy deposits.
They might also not be worth drifting as they will not contribute to the final waveform.
Merging this PR would remove these hits in pet_to_stp

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (eaae6ee) 13.60% compared to head (2aa6a5c) 13.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   13.60%   13.58%   -0.03%     
==========================================
  Files          22       22              
  Lines         669      670       +1     
==========================================
  Hits           91       91              
- Misses        578      579       +1     
Files Changed Coverage Δ
src/pet_to_stp.jl 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oschulz oschulz requested a review from sagitta42 August 5, 2023 17:52
@sagitta42
Copy link
Contributor

Our original idea was to somehow preserve the "original" event ID to be able to compare later performance of A/E cut, for example, based on the "truth" information. So, for example, in the pss->raw part, if the pulse doesn't trigger, it is not simply removed from the final raw file, but is replaced with an all-zero "waveform" to preserve the number of events.

So, this said, in cases where there are hits that don't have energy deposition (how is that even possible, by the way?..), those hits are not the only ones in the event? As in, there aren't events that are somehow "zero-deposition" events, consisting only of such hits that will be removed?

@oschulz
Copy link
Contributor

oschulz commented Oct 5, 2023

Good to merge from my side.

@oschulz oschulz merged commit 624a406 into legend-exp:main Oct 5, 2023
@fhagemann fhagemann added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Nov 8, 2023
@fhagemann fhagemann deleted the stp branch November 8, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants