Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove propdict #66

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Remove propdict #66

merged 1 commit into from
Nov 22, 2024

Conversation

fhagemann
Copy link
Contributor

The method propdict is basically an alias of PropDicts.readprops.
Thinking about an upcoming breaking release of LegendGeSim, propdict should be removed in favor of readprops.
I have deprecated propdict in this PR.

@fhagemann fhagemann added the breaking Changes syntax compared to older versions label Nov 18, 2024
@fhagemann
Copy link
Contributor Author

Also looks like propdict was not exported, so it should affect too many people hopefully

@fhagemann
Copy link
Contributor Author

fhagemann commented Nov 18, 2024 •
edited
Loading

The last commit is cherry-picked from #63 (be83000), should resolve the failing tests.

oschulz
oschulz requested changes Nov 18, 2024
View reviewed changes
src/detector.jl Outdated Show resolved Hide resolved
src/temp_utils.jl Outdated Show resolved Hide resolved
@fhagemann fhagemann force-pushed the deprecated branch 2 times, most recently from 3d69b20 to 9261eaa Compare November 19, 2024 19:47
@fhagemann fhagemann changed the title Deprecate propdict Remove propdict Nov 19, 2024
@fhagemann
Copy link
Contributor Author

@oschulz Please check and merge at your earliest convenience.

oschulz
oschulz requested changes Nov 20, 2024
View reviewed changes
src/detector.jl Outdated Show resolved Hide resolved
@fhagemann
Copy link
Contributor Author

I also had to update the Project.toml because readlprops was introduced only in [email protected].

@fhagemann fhagemann requested review from oschulz and removed request for oschulz November 20, 2024 15:32
@oschulz oschulz merged commit aad2868 into main Nov 22, 2024
5 checks passed
@oschulz oschulz deleted the deprecated branch November 22, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oschulz oschulz oschulz approved these changes

Assignees
No one assigned
Labels
breaking Changes syntax compared to older versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhagemann @oschulz