Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for SignalAnalysis to 0.10, (keep existing compat) #72

Merged

Conversation

github-actions[bot]
Copy link

This pull request changes the compat entry for the SignalAnalysis package from 0.4, 0.5, 0.6, 0.7, 0.8, 0.9 to 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 0.10.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@oschulz oschulz force-pushed the compathelper/new_version/2024-11-24-00-23-47-436-03406386011 branch from bc723a5 to 5d62ec6 Compare November 24, 2024 00:23
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.66%. Comparing base (aad2868) to head (34c100f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   66.71%   66.66%   -0.05%     
==========================================
  Files          20       20              
  Lines         706      705       -1     
==========================================
- Hits          471      470       -1     
  Misses        235      235              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@oschulz oschulz requested a review from fhagemann November 24, 2024 09:46
Copy link
Contributor

@fhagemann fhagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me like SignalAnalysis is only used for PinkGaussian, which was not modified by the latest 0.10 release.

@oschulz oschulz merged commit a6b407b into main Nov 25, 2024
8 checks passed
@oschulz oschulz deleted the compathelper/new_version/2024-11-24-00-23-47-436-03406386011 branch November 25, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants