renamed variables in lq_cut, changed expression handling #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
All tests are failing. I think you need to rename things in there too |
theHenks
requested changes
Dec 13, 2024
fhagemann
requested changes
Dec 13, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
- Coverage 21.33% 20.80% -0.53%
==========================================
Files 36 36
Lines 3305 3384 +79
==========================================
- Hits 705 704 -1
- Misses 2600 2680 +80 ☔ View full report in Codecov by Sentry. |
theHenks
requested changes
Dec 19, 2024
ext/LegendSpecFitsRecipesBaseExt.jl
Outdated
| @@ -1275,7 +1275,7 @@ end | |||
|
|
|||
| # recipe for the lq_drift_time_correction report | |||
|
|
|||
| @recipe function f(report::NamedTuple{(:lq_prehist, :lq_report, :drift_prehist, :drift_report, :lq_box, :drift_time_func, :DEP_left, :DEP_right)}, e_cal, dt_eff, lq_e_corr, plot_type::Symbol) | |||
| @recipe function f(report::NamedTuple{(:lq_report, :drift_report, :lq_box, :drift_time_func, :DEP_left, :DEP_right)}, e_cal, dt_eff, lq_e_corr, plot_type::Symbol) | |||
There was a problem hiding this comment.
What is the plot_type doing? Can this be a kwarg?
There was a problem hiding this comment.
plot_type specifies which one the different plots should be plottet.
Should i implement this by picking one them as a default plot?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes for the lq_cut
lq_ctc_correctionlq_e_corr_expressionanddt_eff_expressionto construct prop funccut_single_peakinsted of own pre-cutting method