Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidecar channels: don't try to clean up previous batch state if in provider mode #327

Open
guggero opened this issue Dec 14, 2021 · 0 comments

Comments

@guggero
Copy link
Member

guggero commented Dec 14, 2021

If a node is providing sidecar channels, it won't be involved in the actual channel opening process.
So in case of a batch rollback (new PrepareMsg without a finalize of the previous batch), there is nothing to clean up.
In fact, the cleanup attempt creates log entries with errors:

2021-12-14 18:15:28.432 [INF] RPCS: Received PrepareMsg for batch=020xxxx, num_orders=1
2021-12-14 18:15:28.439 [WRN] FNDG: Unable to unregister funding shim (pendingChanID=2dxxxx) for order=8ff7xxx
2021-12-14 18:15:28.444 [DBG] FNDG: Cleaning up incomplete/replaced pending channel in lnd was unsuccessful for order=8ff7xxxx (channel_point=d3c5faxxxx:0), assuming timeout when funding: rpc error: code = Unknown desc = unable to find closed channel summary
positiveblue pushed a commit to positiveblue/pool that referenced this issue Oct 11, 2022
…itest

itest: add test for sidecar cancellation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant