From 3c65c9466568f76a90c459a516a3bfdcfa95744e Mon Sep 17 00:00:00 2001 From: Sergey Bronnikov Date: Fri, 29 Nov 2024 14:29:21 +0300 Subject: [PATCH] corpus: remove submodule A Git submodule was introduced in commit 341ac1ea1619 ("corpus: initial integration"). The main idea was to keep in sync source code of tests and their seed corpus. However, this approach is not convenient: - seed corpus updates often and someone need to regularly bump submodule version, otherwise outdated seed corpus is used - seed corpus takes about 5Gb and git clone of repository with tests takes significant time --- .clusterfuzzlite/Dockerfile | 1 - .github/workflows/test.yaml | 3 --- .gitmodules | 3 --- README.md | 4 +++- corpus | 1 - 5 files changed, 3 insertions(+), 9 deletions(-) delete mode 100644 .gitmodules delete mode 160000 corpus diff --git a/.clusterfuzzlite/Dockerfile b/.clusterfuzzlite/Dockerfile index 6bb43fe..1061003 100644 --- a/.clusterfuzzlite/Dockerfile +++ b/.clusterfuzzlite/Dockerfile @@ -12,6 +12,5 @@ RUN apt-get update && apt-get install -y \ COPY . $SRC/lua-c-api-tests WORKDIR $SRC/lua-c-api-tests -RUN rm -rf corpus RUN git clone --depth 1 --branch cfl https://github.com/ligurio/lua-c-api-corpus corpus COPY .clusterfuzzlite/build.sh $SRC/ diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 61a3970..4c45ac1 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -37,9 +37,6 @@ jobs: runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v4 - with: - fetch-depth: 0 - submodules: recursive - name: Setup common packages run: | diff --git a/.gitmodules b/.gitmodules deleted file mode 100644 index 46ab70f..0000000 --- a/.gitmodules +++ /dev/null @@ -1,3 +0,0 @@ -[submodule "corpus"] - path = corpus - url = https://github.com/ligurio/lua-c-api-corpus diff --git a/README.md b/README.md index 77f0284..291e7d6 100644 --- a/README.md +++ b/README.md @@ -19,7 +19,9 @@ LuaJIT). ### Building ```sh -git clone --jobs $(nproc) --recursive https://github.com/ligurio/lua-c-api-tests +git clone https://github.com/ligurio/lua-c-api-tests +cd lua-c-api-tests +git clone https://github.com/ligurio/lua-c-api-corpus CC=clang CXX=clang++ cmake -S . -B build -DCMAKE_BUILD_TYPE=Debug -DUSE_LUA=ON [-DUSE_LUAJIT=ON] cmake --build build --parallel ``` diff --git a/corpus b/corpus deleted file mode 160000 index a823138..0000000 --- a/corpus +++ /dev/null @@ -1 +0,0 @@ -Subproject commit a823138bf0f4bb64b782776d1397384e1bc60a99