Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Wrong font in chat list and composer #2159

Open
tprudentova opened this issue Nov 26, 2024 · 9 comments
Open

[Bug] Wrong font in chat list and composer #2159

tprudentova opened this issue Nov 26, 2024 · 9 comments
Assignees
Labels
bug Something isn't working QA::Medium 🐉 regression Bug that appeared after release or reappeared

Comments

@tprudentova
Copy link
Collaborator

2.6.10, chat.stg.lin-saas.com, all platforms

The font in chat list and the composer currently is regular

Expected: the font is medium

5346139127445316278

@tprudentova tprudentova added bug Something isn't working QA::Medium 🐉 regression Bug that appeared after release or reappeared labels Nov 26, 2024
@hoangdat
Copy link
Member

what is your composer @tprudentova ?

@hoangdat
Copy link
Member

for composer, we followed: https://www.figma.com/design/uLw3iWnOEGaRlJnfPz4Pv0/Twake-%5BMatrix%5D?node-id=26163-16213&t=EyTZEFGsF79RKGh4-4. Please confirm @DianaPotokina @shepilov @tprudentova @Bobpodvalnyi . What is the right direction?
You are one team, speak the same language, and then have 2 direction to other team in different language. Then change and change and change.

Screenshot 2024-11-26 at 22 12 35

@Bobpodvalnyi
Copy link

@hoangdat the issue is not in the size of font but in the font thickness. it has to be medium but not regular. In prod it's looks like regular but not medium. Look it's "Medium" but not "Regular"
image

@Bobpodvalnyi
Copy link

and the text in composer while you typing has to be the same "Medium"but not "Regular"
image

@hoangdat
Copy link
Member

Figma: M3/body/large

Screenshot 2024-11-27 at 11 05 20

In Flutter: M3/body/large

image

In coding, to strictly follow M3 and avoiding boilerplate, we always depend on the name of typhography: M3/body/large. The same typography but the different value.

The problem here: Figma have updated version, but Flutter engine (which use for TWAKE CHAT) still not. I also discussed this with Khanh before: Please dont update Design System frequently.

@tprudentova tprudentova removed the 🐉 regression Bug that appeared after release or reappeared label Nov 27, 2024
@Bobpodvalnyi
Copy link

Screenshot 2024-11-27 at 15 28 40
could you explain me Why do you have "inter_regular" listed but not inter in the family.
Inter regular doesn't have a weight of 500

@Bobpodvalnyi
Copy link

There have been no updates to the system design file for the last 11 months. So it's not about updates @hoangdat

@tprudentova tprudentova added the 🐉 regression Bug that appeared after release or reappeared label Nov 27, 2024
@Bobpodvalnyi
Copy link

Bobpodvalnyi commented Nov 27, 2024

@hoangdat By your logic, the two texts should not be different since they both have a weight of 500
The text in the bubble message really has a weight of 500 but the text in the input field and in the chat list is different. you have gone something wrong.
Screenshot 2024-11-27 at 16 37 27

@DianaPotokina
Copy link

yes, fonts are different. @hoangdat find the real reason why it's like this. It needs to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA::Medium 🐉 regression Bug that appeared after release or reappeared
Projects
None yet
Development

No branches or pull requests

5 participants