Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] README: Mark sysctl as always required #371

Closed
1 task done
hoang-himself opened this issue Dec 26, 2024 · 2 comments
Closed
1 task done

[FEAT] README: Mark sysctl as always required #371

hoang-himself opened this issue Dec 26, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@hoang-himself
Copy link

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Sysctl parameter should be required in both server and client mode
https://github.com/linuxserver/docker-wireguard/blob/master/readme-vars.yml#L40

Reason for change

I was having problems with this image using rootless Podman, and I found that the sysctl parameter is necessary in server mode
I have not tried with rootful Podman or Docker, please advise otherwise

Proposed code change

desc: "Required."

@hoang-himself hoang-himself added the enhancement New feature or request label Dec 26, 2024
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@aptalca
Copy link
Member

aptalca commented Dec 26, 2024

It is not always required

@hoang-himself hoang-himself closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2024
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants