output file: extension

[vincent-lefort]

When configuring a service with an output file, the 'extension' field behaviour is weird. If defined with 'name' and 'extension' fields, a remote output file is correctly retreived by WAVES, but is nammed on the local file system without the extension. Thus, we recommend not to use the 'extension' field.

[marcoooo]

I'll have a look, this is probabely related to this part of the code:

waves-core/waves/wcore/models/jobs.py

Line 955 in d79e779

class JobOutputManager(models.Manager):

waves-core/waves/wcore/models/jobs.py

Line 997 in d79e779

class JobOutput(Ordered, Slugged, UrlMixin, ApiModel):

more specifically there

waves-core/waves/wcore/models/jobs.py

Line 1058 in d79e779

def file_name(self):

Expected output are created here:

waves-core/waves/wcore/models/jobs.py

Line 538 in d79e779

def create_default_outputs(self):

waves-core/waves/wcore/api/v2/serializers/services.py

Line 36 in d79e779

('file_name', output.file_pattern),

[Sylmila]

in the same way, if output "File name" is inserted without extension : "output" instead of "output.txt". The jobs details page (/waves/jobs/xxxxx) always give an output file 'Not available for now' because WAVES search for a file "output." instead of just "output"

[marcoooo]

I finally figured it out. Extension is not used to compute expected output file full name. Only output value is used. In fact this was made on purpose because extension is only supposed to help adding correct headers when downloading submission output.

[marcoooo]

in the same way, if output "File name" is inserted without extension : "output" instead of "output.txt". The jobs details page (/waves/jobs/xxxxx) always give an output file 'Not available for now' because WAVES search for a file "output." instead of just "output"

Should be fixed: https://github.com/lirmm/waves-core/tree/bugfix/files_inputs.
Before submitting PR, I'll correct other tickets: #11 and #1

[marcoooo]

@vincent-lefort can you confirm this has been fixed in v1.6.7?