Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kindly request #177

Closed
vassilis-panos opened this issue Jan 4, 2025 · 17 comments
Closed

Kindly request #177

vassilis-panos opened this issue Jan 4, 2025 · 17 comments
Assignees
Labels
question Further information is requested

Comments

@vassilis-panos
Copy link

I would like to kindly ask you to at least change the name of this fork. Thank you

@vassilis-panos vassilis-panos added the enhancement New feature or request label Jan 4, 2025
@litinoveweedle
Copy link
Owner

Hello Vassilis, is there an real life issue/reason behind your request? The primary reason for this repo to exists is to give users of the original (yours) SmartIR an easy way switch to maintained project. If I would change the name I will make it more complex for them.

@litinoveweedle litinoveweedle added question Further information is requested and removed enhancement New feature or request labels Jan 4, 2025
@vassilis-panos
Copy link
Author

I never said I will stop maintaining the project. Also in the next few days I will submit the project to HACS. So please kindly if you want to maintain your repository, at least give it another name.

@geirskogul
Copy link

I never said I will stop maintaining the project. Also in the next few days I will submit the project to HACS. So please kindly if you want to maintain your repository, at least give it another name.

There were no updates for months and three succeeding HAOS updates broke the original because the original maintainer (you) didn't keep up with breaking changes. I may not be the savviest but I easily moved to this one when I saw that it was being actively maintained and was already on HACS. It had been weeks since even the last touching of the main branch, and months and months since the last real update (that was broken anyway). In the spirit of open souce, and github itself, shouldn't you be looking over this fork and integrating it into the main branch because the code is updated and works with HA's mentality regarding entities versus devices, and because this one doesn't require file manipulation (on new installs)? Seems like more work than doing it all over.

Plus, this fork works wonderfully with HACS already. If you decide to finally wake up and take action over what seemed like a long-abandoned project, and force a name-change issue, thousands of people with both your main branch and this fork will be angry at one person: you.

@geirskogul
Copy link

This repo has a different name anyway, this is litinoveweedle/SmartIR, not vassilis/SmartIR. That's how github works. This fork is this fork and your fork (the original, again I say abandoned) is your fork. This shows up under litinoveweedle/SmartIR in HACS, this one has been maintained, this one didn't break three times over the last two months and spark entire forum threads and Discord discussions like yours did. Nobody is stealing your project, you abandoned it. You weren't there for the troubleshooting. You didn't seem to care.

While I may not know much, I know that this shouldn't bother anybody and you're only gonna make it worse if you continue to ignore how the world works.

@vassilis-panos
Copy link
Author

Just rename your fork

@geirskogul
Copy link

That's not how open source works! What the hell? That's why they're called forks!

@vassilis-panos
Copy link
Author

That's why I'm asking you to just change the name.

@litinoveweedle
Copy link
Owner

I never said I will stop maintaining the project. Also in the next few days I will submit the project to HACS. So please kindly if you want to maintain your repository, at least give it another name.

Well it is not about what you say or said, but what about you do or did. Your project was unmaintained, non functional with hundreds issues and open PRs. I would say that this is how exactly unmaintained project looks like.

@litinoveweedle
Copy link
Owner

litinoveweedle commented Jan 7, 2025

That's why I'm asking you to just change the name.

I am afraid that you didn't realize, that you aren't replying to me, but to one user of this repo. Although I do agree to his opinion.

This is still fork of your repo, with full disclosure about its origin on the index page. I do not know, if by change of name, you mean the name in the text, or repository name. Because the later one will break functionality of the updates for all users of it. And that would be the direct opposite of the thing I am tried to achieve - to keep user integration working.

@geirskogul
Copy link

That's why I'm asking you to just change the name.

are you a weird bot?

@vassilis-panos
Copy link
Author

I might be. But look at this, some bots have better manners!

@vassilis-panos
Copy link
Author

So the answer to my request is negative?

@litinoveweedle
Copy link
Owner

So the answer to my request is negative?

You did not answered my question. What does you mean by renaming? And what will it mean for the users?

@vassilis-panos
Copy link
Author

Yes, rename the fork because it has been extensively modified at device codes part from the original.

@litinoveweedle
Copy link
Owner

Yes is not a valid answer to my question. Also I do not understand your reasoning. Forks can deviate from the original, that is kind of the reason of forking.

@jhstatewide
Copy link

(peanut gallery here)
As far as I am concerned, this fork is named: litinoveweedle/SmartIR

@vassilis-panos For better or worse, this is open source. Your original repo is able to be forked by anyone and used. Open source doesn't always mean when we release source that people make only changes we would agree with. I am glad you will be making updates to the original repo, but keep in mind this fork only exists because it answers the needs of some users that were not getting met by the original project.

If YOU wish to take on the labor to rename the software in your repo, you have the freedom to do so.

@vassilis-panos
Copy link
Author

Good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants