You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of the coding choices here are odd. For instance, why does the llmware.library.Library class take no arguments in its __init__ method, and then require calling create_new_library? __init__ should just take the requisite arguments, and create_new_library should probably be a classmethod, as it's basically just a factory function for llmware.library.Library.
Other oddities: docstrings are just comments. And there's no indication in either the examples or the comments that you need to have a mongo database already running, and it's not clear how to configure it. Instead I had go through the exception that was raised and it seems like I have to set an environment variable, which is then picked up by the LLMConfig object, which is in turn picked up by the Library. But why can't I just pass a client, or some other generic object with read and write methods directly to my library? It's all very roundabout and opaque. The tools here seem very useful, but many of the design choices raise some red flags.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Some of the coding choices here are odd. For instance, why does the
llmware.library.Library
class take no arguments in its__init__
method, and then require callingcreate_new_library
?__init__
should just take the requisite arguments, andcreate_new_library
should probably be a classmethod, as it's basically just a factory function forllmware.library.Library
.Other oddities: docstrings are just comments. And there's no indication in either the examples or the comments that you need to have a mongo database already running, and it's not clear how to configure it. Instead I had go through the exception that was raised and it seems like I have to set an environment variable, which is then picked up by the
LLMConfig
object, which is in turn picked up by theLibrary
. But why can't I just pass a client, or some other generic object withread
andwrite
methods directly to my library? It's all very roundabout and opaque. The tools here seem very useful, but many of the design choices raise some red flags.Beta Was this translation helpful? Give feedback.
All reactions