Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up GitHub Actions #6

Open
1 task done
AshesOfEther opened this issue Apr 19, 2023 · 0 comments
Open
1 task done

chore: set up GitHub Actions #6

AshesOfEther opened this issue Apr 19, 2023 · 0 comments
Assignees

Comments

@AshesOfEther
Copy link
Member

Area

Monorepo

Problem

At the moment, it's easy to push a commit that breaks something without one realizing it, especially when the breakage is on another platform. If more commits are laid on top, then once the issue is detected, it's harder to find out what change caused it.

Suggested solution

We should set up GitHub Actions for this monorepo, just like we do for the lokinit repo. This provides feedback across platforms mere minutes after push, and makes it possible to quickly detect what set of commits caused the problem, hugely speeding up debugging.

This being a monorepo, it means that we should take care not to build packages that are unaffected, to speed up build time. The best solution to this might just be to cache CI runs and let Cargo figure out what to rebuild.

Build minutes should not be a concern, as GitHub doesn't limit us in this regard as long as we aren't straight up abusing Actions. The limit for the cache is 10 GB, so we should also be somewhat safe there.

Alternatives

We could not do this, and live with the problem laid out above. This would probably not be a huge deal, but CI is nice to have.

Additional information

No response

Checks

  • I have checked for existing issues about this, and did not
    find any.
@AshesOfEther AshesOfEther self-assigned this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant