Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description to modules in configuration screen #80

Open
efa2d19 opened this issue May 31, 2023 · 6 comments
Open

Add description to modules in configuration screen #80

efa2d19 opened this issue May 31, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@efa2d19
Copy link
Member

efa2d19 commented May 31, 2023

Is your feature request related to a problem? Please describe.

  • It's kinda hard to understand what modules will do when you select them. Opening default_modules.py every time isn't the solution here.

Describe the solution you'd like

  • Add some kind of banner on top of the modules selection screen with some info about them. Maybe inquirer has something to offer.

Describe alternatives you've considered

  • Switch from inquirer to something else if implementation would be hard or impossible.
@efa2d19 efa2d19 added the enhancement New feature or request label May 31, 2023
@efa2d19 efa2d19 added this to the v3.1.0 milestone May 31, 2023
@efa2d19 efa2d19 self-assigned this May 31, 2023
@efa2d19 efa2d19 added the internal Must be resolved by internal team members label May 31, 2023
@rizkyarlin
Copy link

Hi @drugsosos I already created a PR in inquirer but I'm not sure how long it's gonna take. How about providing -v to make the Checkbox choices also in verbose mode. We will do some mapping between module and its description anyway, CMIIW

@efa2d19
Copy link
Member Author

efa2d19 commented Aug 2, 2023

Hi @drugsosos I already created a PR in inquirer but I'm not sure how long it's gonna take. How about providing -v to make the Checkbox choices also in verbose mode. We will do some mapping between module and its description anyway, CMIIW

Hey. Thanks for your contribution 💙
Not fully understood about verbose mode, can you elaborate?

@rizkyarlin
Copy link

like when they run mac-cleanup -v

The checkbox will be:
[ ] adobe: Clearing Adobe Cache at ~/Library/Application Support/Adobe/Common/Media Cache Files/*
[ ] chrome: Clearing Google Chrome Cache at ~/Library/Application Support/Google/Chrome/Default/Application Cache/*
......

@efa2d19
Copy link
Member Author

efa2d19 commented Aug 2, 2023

like when they run mac-cleanup -v

The checkbox will be: [ ] adobe: Clearing Adobe Cache at ~/Library/Application Support/Adobe/Common/Media Cache Files/* [ ] chrome: Clearing Google Chrome Cache at ~/Library/Application Support/Google/Chrome/Default/Application Cache/* ......

Good idea actually, but with technical difficulties:
I don't think it'll fit inside 100x30 (approx. default terminal unmaximized window size) and soft wraps don't look good imho.
I'll create a new issue for that or you can if you wish 😉

@rizkyarlin
Copy link

Good call. I didn't think about the terminal size since I always open a big terminal window 🤣

@efa2d19 efa2d19 assigned rizkyarlin and unassigned efa2d19 Aug 2, 2023
@efa2d19 efa2d19 added help wanted Extra attention is needed and removed internal Must be resolved by internal team members labels Aug 2, 2023
@efa2d19
Copy link
Member Author

efa2d19 commented Aug 2, 2023

@rizkyarlin Assigned this one to you 😉

@efa2d19 efa2d19 modified the milestones: v3.1.0, v3.2.0 Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants