Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think it's the right time to upgrade to .NET 6 :) #169

Open
ghost opened this issue Nov 9, 2021 · 4 comments
Open

I think it's the right time to upgrade to .NET 6 :) #169

ghost opened this issue Nov 9, 2021 · 4 comments

Comments

@ghost
Copy link

ghost commented Nov 9, 2021

Mads, please, do you have this in plan ?

@dynamoRando
Copy link
Contributor

dynamoRando commented Nov 18, 2021

Just an FYI - I tried upgrading to .NET6 locally and ran into the following error on startup:

TypeLoadException: Could not load type 'Microsoft.AspNetCore.Http.Features.IHttpBufferingFeature' from assembly 'Microsoft.AspNetCore.Http.Features, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'.

WebMarkupMin.AspNetCore2.WebMarkupMinMiddleware.ProcessAsync(HttpContext context, bool useMinification, bool useCompression)
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start<TStateMachine>(ref TStateMachine stateMachine)
System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start<TStateMachine>(ref TStateMachine stateMachine)
WebMarkupMin.AspNetCore2.WebMarkupMinMiddleware.ProcessAsync(HttpContext context, bool useMinification, bool useCompression)
WebMarkupMin.AspNetCore2.WebMarkupMinMiddlewareBase.Invoke(HttpContext context)
WebEssentials.AspNetCore.OutputCaching.OutputCacheMiddleware.ServeFromMvcAndCacheAsync(HttpContext context)
WebEssentials.AspNetCore.OutputCaching.OutputCacheMiddleware.InvokeAsync(HttpContext context)
Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
WilderMinds.MetaWeblog.MetaWeblogMiddleware.Invoke(HttpContext context, MetaWeblogService service)
Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

To fix:

  • Remove the reference to WebMarkupMin.AspNetCore2 in the NuGet dependencies
  • Update to WebMarkupMin.AspNetCore6
  • Update the reference from WebmarkupMin.AspNetCore2 in Startup.cs to WebMarupMin.AspNetCore6

That should be it; as far as I can tell.

@dynamoRando
Copy link
Contributor

Created PR #171 for this

@ghost
Copy link
Author

ghost commented Nov 19, 2021

Great, but it would also use the latest features that .NET 6 allows. Do you want to do that ? :)

@xaberue
Copy link

xaberue commented Jul 26, 2022

Seems that the project already has this upgrade developed and merged, can be closed that issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants