Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] [PHPDOC] Fix bad phpdoc Magento\Framework\App\Config\ScopeConfigInterface #39492

Open
4 of 5 tasks
m2-assistant bot opened this issue Dec 18, 2024 · 2 comments · May be fixed by #39199
Open
4 of 5 tasks

[Issue] [PHPDOC] Fix bad phpdoc Magento\Framework\App\Config\ScopeConfigInterface #39492

m2-assistant bot opened this issue Dec 18, 2024 · 2 comments · May be fixed by #39199
Labels
Area: Framework Component: Framework/App Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 18, 2024

This issue is automatically created based on existing pull request: #39199: [PHPDOC] Fix bad phpdoc Magento\Framework\App\Config\ScopeConfigInterface


Description (*)

This PR fix bad phpdoc in Magento\Framework\App\Config\ScopeConfigInterface :

  • getValue : The $scopeCode argument can accept StoreInterface
  • isSetFlag : The $scopeCode argument can accept StoreInterface

Here is an example where the type StoreInterface is used :

if ($scope !== 'default') {
if (is_numeric($scopeCode) || $scopeCode === null) {
$scopeCode = $this->scopeCodeResolver->resolve($scope, $scopeCode);
} elseif ($scopeCode instanceof \Magento\Framework\App\ScopeInterface) {
$scopeCode = $scopeCode->getCode();
}
if ($scopeCode) {
$configPath .= '/' . $scopeCode;
}
}

For example, with PHPSTAN is very complicated to setup the project with level 5 or higher :(

Capture d’écran du 2024-09-23 10-28-32

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

Setup PHPSTAN with level 5 or higher and run check.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Dec 18, 2024
@engcom-Dash engcom-Dash added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Framework/App Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Framework labels Dec 18, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13537 is successfully created for this GitHub issue.

Copy link
Author

m2-assistant bot commented Dec 18, 2024

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: Framework/App Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants