Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] clearing the Global default welcome text will cause a NULL parameter CRASH #39507

Closed
m2-assistant bot opened this issue Dec 24, 2024 · 5 comments · May be fixed by #39501
Closed

[Issue] clearing the Global default welcome text will cause a NULL parameter CRASH #39507

m2-assistant bot opened this issue Dec 24, 2024 · 5 comments · May be fixed by #39501
Assignees
@engcom-Bravo
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.x Indicates original Magento version for the Issue report.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 24, 2024

This issue is automatically created based on existing pull request: #39501: clearing the Global default welcome text will cause a NULL parameter CRASH

Description (*)

Clearing the Global default Welcome Text will cause a NULL parameter to be passed to Escaper.php.
Added a parameter sanity check to avoid the site crash.

[2024-12-20T17:21:42.186669+00:00] main.CRITICAL: TypeError: addslashes(): Argument #1 ($string) must be of type string, null given in /home/jetrails/encircle.markets/html/vendor/magento/framework/Escaper.php:440
Stack trace:
#0 /home/jetrails/encircle.markets/html/vendor/magento/framework/Escaper.php(440): addslashes(NULL)
#1 /home/jetrails/encircle.markets/html/vendor/magento/module-theme/Block/Html/Header.php(62): Magento\Framework\Escaper->escapeQuote(NULL, true)
#2 /home/jetrails/encircle.markets/html/vendor/magento/module-theme/view/frontend/templates/html/header.phtml(11): Magento\Theme\Block\Html\Header->getWelcome()

Related Pull Requests

none

Fixed Issues (if relevant)

none

Manual testing scenarios (*)

  1. add a website to the 'All Stores' configuration page ./admin/system_store/index/key/…
  2. remove the Global default Welcome Text from the first item in the Content | Design/Configuration list ./theme/design_config/index/key/…
    *1. remove the Welcome Text from the [Header] section of the Global default.
  3. restart the web server; reload the home page for the newly added website [BOOM].

I have a two website configuration and removed the global default in favor of the configuration for the specific websites, causing my site to crash. I think the issue is that the newly added website started with no value set for the Welcome Text.

Questions or comments

Contribution checklist (*)

  • [ √ ] Pull request has a meaningful description of its purpose
  • [ √ ] All commits are accompanied by meaningful commit messages
  • [ - ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ - ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ - ] All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot mentioned this issue Dec 24, 2024
Open
1 task
@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Dec 24, 2024
@engcom-Bravo engcom-Bravo self-assigned this Dec 24, 2024
@m2-assistant M2 Assistant
Copy link
Author

m2-assistant bot commented Dec 24, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Dec 24, 2024
@engcom-Bravo
Copy link
Contributor

Hi @ergohack,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Screenshot 2024-12-26 at 10 27 35 am Screenshot 2024-12-26 at 10 27 18 am

We have created one more website and removed Header section of the Global default.The Website is working fine and it didn't crash.

Could you please try to reproduce the issue in Latest 2.4-develop instance and please let us know if we are missing anything.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Dec 26, 2024
@engcom-Bravo engcom-Bravo moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Dec 26, 2024
@ergohack
Copy link
Contributor

This was reproduced on a 2.4.6-p8 production environment, … If it is not reproducible on 2.4-develop, then I close the pull request.

@engcom-Bravo
Copy link
Contributor

Hi @ergohack,

Thanks for your Update.

Since the issue is no more reproducible in Latest 2.4-develop instance we are closing this issue.Please feel free to reopen the issue.

Thanks.

@hostep
Copy link
Contributor

hostep commented Dec 27, 2024

I believe it was fixed in Magento 2.4.7, more details in this issue: #37208, especially this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engcom-Bravo engcom-Bravo

Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.x Indicates original Magento version for the Issue report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clearing the Global default welcome text will cause a NULL parameter CRASH ergohack/magento2
3 participants
@hostep @ergohack @engcom-Bravo