Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in BW estimation #4

Open
gaoxiongzeng opened this issue Dec 9, 2020 · 0 comments
Open

Issues in BW estimation #4

gaoxiongzeng opened this issue Dec 9, 2020 · 0 comments

Comments

@gaoxiongzeng
Copy link

Based on my testing, the tcp-bbr may over-estimate the BW during loss recovery. The packet.delivered in BBR paper is recorded by the m_lastAckedSeq, which is the cumulative ACK while there may be lots of SACK ignored. During loss recovery, new data can still get sent if window allows. This can potentially lead to BW over-estimation when their ACKs get back and cumulatively ack all the already SACKed data.

It seems that the line 389 of tcp-bbr.cc, i.e., if (!m_in_retrans_seq) {, tries to avoid the issue, but not completely resolves it. To address it, we can extend that line to:
if (!m_in_retrans_seq && tcb->m_congState==TcpSocketState::CA_OPEN) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant