Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring from Snapshot now opens all tabs to top bar with Panels all empty #1942

Open
RocktSurgeon opened this issue Jan 2, 2025 · 0 comments

Comments

@RocktSurgeon
Copy link

RocktSurgeon commented Jan 2, 2025

Steps to reproduce

  • SideBerry Installed/configured with no changes to it or Firefox settings or addons for >6 months
  • Firefox set to "Open Previous Windows and Tabs", Sideberry Auto Snapshots every 12 hours
  • Have many (>1000) tabs across multiple Sideberry panels, using 1 window
  • Sessions restored accurately with tabs in correct Panels every time until now.
  • Check Snapshots are being created as expected and they accurately reflect the expected Panel organization/tab tree structure

Actual behavior

  • After a PC crash, on opening Firefox the session was empty.
  • Sidebar shows all panels (empty) as if it is a new/clean/second window.
  • Re-checked Sideberry Snapshots, ensured good snapshot with full panel structure (all correctly reflects the expected tab structure)
  • On Restore from Snapshot,
    >all tabs load only to main Firefox Top Bar
    >Side Sidebar shows all Panels as expected, but all are empty
    >Opening a new tab only creates it in Firefox Top Bar, panels remain empty
  • "Reload add-on" from Sideberry Settings>Help>
    >After loading, all tabs show up in 1st Panel (not separated to correct panel per Snapshot)
    >No tree structure as well

Notes from Logs below:

On initial snapshot restore, log shows messages through line 17: [sidebar:224] Init end: 90ms chunk-4KZVVU6Z.js:2:7890
Remaining log appears after triggering Reload Add-On Seems like the below lines may be showing the issues happening?
[sidebar:574] Tabs.findCachedData: mismatched: 4081 4081 8 chunk-4KZVVU6Z.js:2:7976
[sidebar:574] Tabs.restoreTabsFromSessionData chunk-4KZVVU6Z.js:2:7890
[sidebar:574] Tabs loading: Cannot find panels: -1 chunk-4KZVVU6Z.js:2:7976
[sidebar:574] Tabs.restoreTabsState: Done: 296ms chunk-4KZVVU6Z.js:2:7890

Troubleshooting/VERY partial mitigation:
Tested partially restoring snapshots by selecting>"Open in Current Panel" with a subset of tabs in the Snapshot Viewer. This restores the tabs with their Tree and Folder structures correct. With large numbers of tabs this isn't a very manageable way to restore after the problem since it involves hundreds to thousands of checkbox clicks manually for the currently panel, but it at least can help with restoring key subsets.

Expected behavior

Restoring all tabs to correct panels with tree structure intact on Restore from Snapshot. At least a workaround would be great if any ideas to get the tab structure back/reflecting the saved Snapshot structure.

For what it's worth, I really value the panels/organization and end up with so many tabs in some panels because I use them to organize background research for projects including reviewing references for research articles and context around them (as well as archives of reviewed/installed mods for games that can get pretty extensive).

System

Windows 11

Firefox version

133.0.3 (64-bit)

Sidebery version

5.2.0

Logs

[bg] Init start chunk-4KZVVU6Z.js:2:7890
[bg] Init end: 271ms chunk-4KZVVU6Z.js:2:7890
[sidebar] Init start 2 chunk-4KZVVU6Z.js:2:7890
[sidebar:224] Sidebar.loadPanels chunk-4KZVVU6Z.js:2:7890
[sidebar:224] Sidebar.loadPanels: Done: 3ms chunk-4KZVVU6Z.js:2:7890
[sidebar:224] Tabs.load chunk-4KZVVU6Z.js:2:7890
[sidebar:224] Tabs.restoreTabsState chunk-4KZVVU6Z.js:2:7890
[bg] IPC.onConnected sidebar 224 chunk-4KZVVU6Z.js:2:7890
[sidebar:574] Sidebar.loadPanels chunk-4KZVVU6Z.js:2:7890
[bg] Windows.isWindowTabsLocked 224 chunk-4KZVVU6Z.js:2:7890
[sidebar:574] Sidebar.loadPanels: Done: 3ms chunk-4KZVVU6Z.js:2:7890
[sidebar:574] Tabs.load chunk-4KZVVU6Z.js:2:7890
[sidebar:574] Tabs.restoreTabsState chunk-4KZVVU6Z.js:2:7890
[sidebar:224] Tabs.restoreTabsFromCache chunk-4KZVVU6Z.js:2:7890
[sidebar:224] Tabs.restoreTabsState: Done: 42ms chunk-4KZVVU6Z.js:2:7890
[sidebar:224] Tabs.load: Done: 48ms chunk-4KZVVU6Z.js:2:7890
[sidebar:224] Init end: 90ms chunk-4KZVVU6Z.js:2:7890
[bg] IPC.onConnected sidebar 574 chunk-4KZVVU6Z.js:2:7890
[bg] Windows.isWindowTabsLocked 574 chunk-4KZVVU6Z.js:2:7890
[sidebar:574] Tabs.findCachedData: mismatched: 4081 4081 8 chunk-4KZVVU6Z.js:2:7976
[sidebar:574] Tabs.restoreTabsFromSessionData chunk-4KZVVU6Z.js:2:7890
[sidebar:574] Tabs loading: Cannot find panels: -1 chunk-4KZVVU6Z.js:2:7976
[sidebar:574] Tabs.restoreTabsState: Done: 296ms chunk-4KZVVU6Z.js:2:7890
[sidebar:574] Tabs.load: Done: 1083ms chunk-4KZVVU6Z.js:2:7890
[sidebar:574] Init end: 1153ms chunk-4KZVVU6Z.js:2:7890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant