Blank line in highlighted code

[PassionPenguin]

Summary

formatted code with many lines defined with raw <pre class="brush: json"> and a blank line following it will have a blank line at the very beginning

Note

Just a glance, there are 133 occurences that are alike and have problems (blank line at the beginning of the code)

---

Note

i'm not sure if this is caused by the format of the document's <pre> code, or is caused by yari? This is caused by yari and rari's addition of <code> (see discussion below)

### URL

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_action#choosing_icon_sizes

Reproduction steps

Expected behavior

Without line-breaking

Actual behavior

Device

Desktop

Browser

Chrome

Browser version

Stable

Operating system

Windows

Screenshot

No response

Anything else?

No response

Validations

• I have read the Community Participation Guidelines.
• I have verified that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• I have checked that this is a concrete bug. For Q&A open a GitHub Discussion.

[yin1999]

The rendered HTML looks good to me. Did you check the row html content of this document (that is, download the document using wget/curl). I can see there is no such an empty line in this <pre> element.

[PassionPenguin]

The rendered HTML looks good to me. Did you check the row html content of this document (that is, download the document using wget/curl). I can see there is no such an empty line in this \<pre\> element.

not this line. check line 24 or line 171, where <code>'s content starts with \n

[PassionPenguin]

the problem may be resolved simply by deleting the \n in the <pre> (but unsure how many content will need to be altered), but i'm curious if adding a triming the rendered pre's first and last blank line process will be better in the markdown processor?

[yin1999]

It may caused by the post processing of HTML in rari: https://github.com/mdn/rari/blob/df364f905549a025f7607fe5086a62a71d9697aa/crates/rari-doc/src/html/rewriter.rs#L119-L122

The adding of <code> tag makes the first empty line would not be ignored by User Agent, see the spec, and the following tests:

[PassionPenguin]

It may caused by the post processing of HTML in rari: https://github.com/mdn/rari/blob/df364f905549a025f7607fe5086a62a71d9697aa/crates/rari-doc/src/html/rewriter.rs#L119-L122

The adding of <code> tag makes the first empty line would not be ignored by User Agent, see the spec, and the following tests:

then we may just remove the blank line at the very begining of the code content to resolve it

[PassionPenguin]

FYI: yari's handler for codeblocks:

yari/build/code-headers.ts

Line 41 in 1ebac4b

const $code = $("<code>").text(code);