-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Patterns] Notification of Dynamic Registration Failure #273
Comments
@leecalcote the issue with sending any notification on failing registration is that "events" bidirectional connection is opened by Meshery Server (which acts like a client to meshery adapter) when it initiates a request on the adapter while the registration process is initiated by the meshery adapter (in this case adapter is the client). Implementing this would be a bit more trickier than sending a WARN event to meshery because there is no channel to send the message. Here's what we can do though: Having said that, the my above suggestion seems bad. Can't think of another better solution to the problem at the moment. // @Revolyssup |
For now, let's change this to minimally providing an INFO log in stdout. Example of successfully registered Istio adapter:
No indication of success or failure. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Something to be addressed in v0.7.0 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@leecalcote Given the new EventStreamer, we can do this now. The only caviat is since we are not currently persisting or maintaining history, if the client connects after the registration has been done then the client won't be notified. Although if the client is already connected, they would get the notification of components being registered. Should I add that feature and close this issue? |
Enhancement Request:
Add info log to verify registration of pattern components (or failure to register pattern components).
Context:
Going forward PatternOps (pattern-based operations) will be used for all of the adapter operations. If an adapter fails to register is capabilities (register its operations), we should denote this in the UI eventually, so the user can see this in the Notification Center.
Immediately, providing an INFO log will be an improvement.
Originally posted by @leecalcote in #269 (comment)
The text was updated successfully, but these errors were encountered: