Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Upgrade to Golang 1.23.4 #586

Closed
Tracked by #12829
leecalcote opened this issue Dec 11, 2024 · 4 comments · Fixed by #589
Closed
Tracked by #12829

[Chore] Upgrade to Golang 1.23.4 #586

leecalcote opened this issue Dec 11, 2024 · 4 comments · Fixed by #589
Assignees
Labels
help wanted Extra attention is needed issue/willfix kind/enhancement Improvement in current feature language/go

Comments

@leecalcote
Copy link
Member

Current Behavior

Project is running golang 1.21.8.

Desired Behavior

Project need updated to golang 1.23.4


Contributor Guides and Resources

@leecalcote
Copy link
Member Author

@devhindo fyi

@devhindo
Copy link
Member

okay, on it.

@devhindo
Copy link
Member

devhindo commented Dec 11, 2024

I think github.com/layer5io/meshkit needs to be updated first
then github.com/meshery/meshery-adapter-library should use the latest version of meshkit after updated
then meshery-linkerd should be updated after that
and only then we upgrade meshery

Reason: there is some compatibilities as the current meshery-linkerd doesn't even compile with the current version of Go due to the incompatable types.CapabiliyType which happens because github.com/meshery/meshery-adapter-library uses an old version of meshkit github.com/layer5io/meshkit v0.6.84 that doesn't have that type.
image

@leecalcote
Copy link
Member Author

@devhindo, yes, I think that you're right. @weilirs, FYI.

We spoke of this on yesterday's dev meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed issue/willfix kind/enhancement Improvement in current feature language/go
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants