Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] fix: resolve deps #272

Closed
wants to merge 1 commit into from

Conversation

VihasMakwana
Copy link
Member

@VihasMakwana VihasMakwana commented Dec 10, 2023

Description

This PR fixes #271

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Vihas Makwana <[email protected]>
Copy link
Member

@theBeginner86 theBeginner86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VihasMakwana!

It doesn't fixes the issue. Would you mind having a look at this log? https://github.com/meshery/meshery-nginx-sm/actions/runs/7159382980/job/19492569783?pr=272#step:20:11

We are failing at initializing Viper.

@VihasMakwana
Copy link
Member Author

@theBeginner86 meh, this might take some time. weird issue.
Will update you once I fix it locally.

@VihasMakwana VihasMakwana changed the title fix: resolve deps [DO NOT MERGE] fix: resolve deps Dec 11, 2023
Copy link

stale bot commented Jan 26, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jan 26, 2024
Copy link

stale bot commented Feb 6, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Failing E2E tests
2 participants