Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golang Lint Check Warnings #575

Open
willcalcote opened this issue Aug 21, 2024 · 4 comments · May be fixed by #579
Open

Golang Lint Check Warnings #575

willcalcote opened this issue Aug 21, 2024 · 4 comments · May be fixed by #579
Assignees
@ShivanshuGupta07
Labels
good first issue Good for newcomers help wanted Extra attention is needed issue/willfix This issue will be worked on kind/chore Necessary task language/go Golang related

Comments

@willcalcote
Copy link

Description
Running make check produces the following warnings and suggestions:

validator/validate.go:17:2: var `schemaPath` is unused (unused)
	schemaPath      = "components.schemas"
	^
config/provider/inmem.go:57:9: SA1019: utils.Unmarshal is deprecated: Use Unmarshal from encoding package. TODO: Replace the usages from all projects. (staticcheck)
	return utils.Unmarshal(l.store[key], result)
	       ^
utils/kubernetes/crd.go:38:8: SA1019: utils.Unmarshal is deprecated: Use Unmarshal from encoding package. TODO: Replace the usages from all projects. (staticcheck)
	err = utils.Unmarshal(string(crdresult), &xcrd)

Expected Behavior
All lint checks pass.
@willcalcote willcalcote added help wanted Extra attention is needed issue/willfix This issue will be worked on kind/chore Necessary task language/go Golang related labels Aug 21, 2024
@welcome Welcome
Copy link

welcome bot commented Aug 21, 2024

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

@willcalcote willcalcote added the good first issue Good for newcomers label Aug 21, 2024
@khabdrick
Copy link

Hello @willcalcote I can work on this

@ShivanshuGupta07
Copy link

@leecalcote @khabdrick, Is there any update on this task? if not can I raise a PR.

@khabdrick
Copy link

@ShivanshuGupta07 you can take it up

ShivanshuGupta07 added a commit to ShivanshuGupta07/meshkit that referenced this issue Aug 25, 2024
@ShivanshuGupta07
resolved Golang Lint Check Warnings meshery#575
b344285
ShivanshuGupta07 added a commit to ShivanshuGupta07/meshkit that referenced this issue Aug 25, 2024
@ShivanshuGupta07
Fix meshery#575: Replaced deprecated utils.Unmarshal and removed unus…
ec5e451 
…ed variables
ShivanshuGupta07 added a commit to ShivanshuGupta07/meshkit that referenced this issue Aug 25, 2024
@ShivanshuGupta07
Fix meshery#575: Replaced deprecated utils.Unmarshal and removed unus…
3535b9b 
…ed variables
ShivanshuGupta07 added a commit to ShivanshuGupta07/meshkit that referenced this issue Aug 25, 2024
@ShivanshuGupta07
Fix meshery#575: Replaced deprecated utils.Unmarshal and removed unus…
8ffa249 
…ed variables

Signed-off-by: Shivanshu Gupta <[email protected]>
@ShivanshuGupta07 ShivanshuGupta07 linked a pull request Aug 25, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShivanshuGupta07 ShivanshuGupta07

Labels
good first issue Good for newcomers help wanted Extra attention is needed issue/willfix This issue will be worked on kind/chore Necessary task language/go Golang related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #575: Replaced deprecated utils.Unmarshal and removed unused variables ShivanshuGupta07/meshkit
3 participants
@willcalcote @khabdrick @ShivanshuGupta07