Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Meshery Server and all Components to Golang 1.23.4 #12829

Closed
3 of 9 tasks
leecalcote opened this issue Dec 3, 2024 · 5 comments · Fixed by meshery/meshsync#349, meshery/meshery-nginx-sm#293, meshery/meshery-adapter-library#164, meshery/meshery-consul#430 or meshery/meshery-cilium#171
Closed
3 of 9 tasks

Upgrade Meshery Server and all Components to Golang 1.23.4 #12829

leecalcote opened this issue Dec 3, 2024 · 5 comments · Fixed by meshery/meshsync#349, meshery/meshery-nginx-sm#293, meshery/meshery-adapter-library#164, meshery/meshery-consul#430 or meshery/meshery-cilium#171
Assignees
@weilirs @devhindo
Labels
help wanted Extra attention is needed kind/chore Necessary task kind/enhancement Improvement in current feature language/go Issues or pull requests that use Golang

Comments

@leecalcote
Copy link
Member

leecalcote commented Dec 3, 2024 •
edited
Loading

Current Behavior

Meshery and its components all use golang 1.21.8 currently. Some packages that Meshery relies upon are no longer compatible with 1.21, but require 1.22 or higher. For example.

go: downloading github.com/99designs/gqlgen v0.17.57
go: github.com/99designs/[email protected] requires go >= 1.22.5 (running go 1.21.8; GOTOOLCHAIN=go1.21.8)
go: github.com/99designs/[email protected] requires go >= 1.22.5 (running go 1.21.8; GOTOOLCHAIN=go1.21.8)
make: *** [graphql] Error 1

Desired Behavior

All components within the Meshery project to support the latest version of Golang (1.23.4).

Implementation

  1. github workflows: Uniformly, upgrade Meshery Server and all its components workflows to Golang 1.23.4.
  2. makefile variables
  3. github repo secret (if applicable)

Acceptance Tests

  1. Meshery Extension providers notified of impending upgrade.
  2. Compatibility of new version confirmed with each component and with Meshery Extension providers.

Contributor Guides and Handbook
@leecalcote leecalcote added kind/enhancement Improvement in current feature help wanted Extra attention is needed kind/chore Necessary task language/go Issues or pull requests that use Golang labels Dec 3, 2024
@leecalcote leecalcote mentioned this issue Dec 3, 2024
Open
@weilirs
Copy link
Contributor

weilirs commented Dec 4, 2024

Can you assign this to me? @leecalcote

@eyeaadil
Copy link

eyeaadil commented Dec 5, 2024

@leecalcote ,can you assign this to me?

@leecalcote
Copy link
Member Author

You bet. There are plenty of components in need of upgrade.

eyeaadil added a commit to eyeaadil/meshery that referenced this issue Dec 5, 2024
@eyeaadil
Fix meshery#12829
fcd5ff5
eyeaadil added a commit to eyeaadil/meshery that referenced this issue Dec 5, 2024
@eyeaadil
Revert "Fix meshery#12829"
b7a49be 
This reverts commit fcd5ff5.
@weilirs weilirs mentioned this issue Dec 5, 2024
Open
1 task
@devhindo
Copy link
Member

Is there anyone working on this? If not, I'm happy to work on it

@leecalcote leecalcote changed the title Upgrade Meshery Server and all Components to Golang 1.23 Upgrade Meshery Server and all Components to Golang 1.23.4 Dec 11, 2024
@weilirs
Copy link
Contributor

weilirs commented Dec 12, 2024

Is there anyone working on this? If not, I'm happy to work on it

Next I'll upgrade Meshkit and test it with the server, feel free to upgrade other components

@devhindo devhindo mentioned this issue Dec 15, 2024
Merged
@weilirs weilirs mentioned this issue Dec 15, 2024
Open
1 task
This was referenced Dec 16, 2024
Open
Merged
Merged
@leecalcote leecalcote reopened this Dec 18, 2024
This was referenced Dec 19, 2024
Open
Closed
Merged
Open
Merged
This was referenced Dec 21, 2024
Merged
Open
Merged
@weilirs weilirs reopened this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weilirs weilirs

@devhindo devhindo

Labels
help wanted Extra attention is needed kind/chore Necessary task kind/enhancement Improvement in current feature language/go Issues or pull requests that use Golang
Projects
None yet
Milestone
No milestone
4 participants
@leecalcote @weilirs @devhindo @eyeaadil