Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need LiquidityPool's sqrtPrice. #2484

Open
chocoford opened this issue Feb 13, 2024 · 1 comment
Open

Need LiquidityPool's sqrtPrice. #2484

chocoford opened this issue Feb 13, 2024 · 1 comment
Assignees
@steegecs
Labels
enhancement New feature or request

Comments

@chocoford
Copy link

chocoford commented Feb 13, 2024 •
edited
Loading

What do you think is missing?
The price of token0/token1 derived from tick is inaccurate.

Describe the solution you'd like
Like Uniswap/v3-subgraph, provide sqrtPrice for LiquidityPool so that we could get the prcise price of pool.

The sqrtPrice is also the essential to calculate the amounts of token0 and token1.
@chocoford chocoford added the enhancement New feature or request label Feb 13, 2024
@bye43 bye43 moved this from Discussions to Backlog in Subgraph Development Feb 13, 2024
@melotik
Copy link
Contributor

melotik commented Feb 15, 2024

@chocoford thank you for this. I will reach out to our DEX expert internally to get an understanding of the priority of this. But regardless of our timeline to getting to this, you are more than welcome to put up a PR to add this and we will support the review/deployment.

cc @steegecs

@melotik melotik assigned steegecs and unassigned bye43 Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steegecs steegecs

Labels
enhancement New feature or request
Projects
Subgraph Development
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chocoford @steegecs @melotik @bye43