You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Provide a narrative description of what you are trying to accomplish:
This PR removes fallback PhpRenderer setup from ZendViewRenderer and moves NamespacedPathStackResolver setup into factory.
ZendViewRenderer requires zend-view renderer and NamespacedPathStackResolver to be explicitly provided at creation time; It won't try to inspect or configure zend-view renderer resolvers and expects them to be configured beforehand.
Are you creating a new feature?
Why is the new feature needed? What purpose does it serve?
This greatly simplifies template renderer and forces separation of concern to avoid the need to modify template renderer to configure its dependencies as has been done in Merge release 2.16.0 into 3.0.x #64
Extra ZendViewRenderer parameter added in Merge release 2.16.0 into 3.0.x #64 is dropped in this PR as that feature is moved into factory.
How will users use the new feature?
Users depending on Zend\Expressive\ZendView\ConfigProvider to configure their container can continue to use the same provided services without change.
Users directly instantiating Zend\Expressive\ZendView\ZendViewRenderer will need to update their code to provide zend-view renderer (PhpRenderer by default) and NamespacedPathStackResolver as constructor parameters; zend-view renderer is expected to be already configured with NamespacedPathStackResolver.
Base your feature on the develop branch, and submit against that branch.
Add only one feature per pull request; split multiple features over multiple pull requests
Provide a narrative description of what you are trying to accomplish:
This PR removes fallback PhpRenderer setup from ZendViewRenderer and moves NamespacedPathStackResolver setup into factory.
ZendViewRenderer requires zend-view renderer and NamespacedPathStackResolver to be explicitly provided at creation time; It won't try to inspect or configure zend-view renderer resolvers and expects them to be configured beforehand.
This greatly simplifies template renderer and forces separation of concern to avoid the need to modify template renderer to configure its dependencies as has been done in Merge release 2.16.0 into 3.0.x #64
Extra ZendViewRenderer parameter added in Merge release 2.16.0 into 3.0.x #64 is dropped in this PR as that feature is moved into factory.
Users depending on
Zend\Expressive\ZendView\ConfigProvider
to configure their container can continue to use the same provided services without change.Users directly instantiating
Zend\Expressive\ZendView\ZendViewRenderer
will need to update their code to provide zend-view renderer (PhpRenderer by default) and NamespacedPathStackResolver as constructor parameters; zend-view renderer is expected to be already configured with NamespacedPathStackResolver.develop
branch, and submit against that branch.CHANGELOG.md
entry for the new feature.Originally posted by @Xerkus at zendframework/zend-expressive-zendviewrenderer#66
The text was updated successfully, but these errors were encountered: