Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old API migrations #4168

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Remove old API migrations #4168

wants to merge 3 commits into from

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Dec 5, 2024

Fixes #4079

Remove deprecated migration steps from the migrate_database function in api_app/api/routes/migrations.py.

  • Migration Steps Removal
    • Remove multiple deprecated migration steps from the migrate_database function.
    • Update the migrate_database function to only include necessary migration steps.
  • Version Update
    • Update the version in api_app/_version.py from "0.19.3" to "0.20.0".
  • Test Updates
    • Remove tests related to deprecated migration steps in api_app/tests_ma/test_api/test_routes/test_migrations.py.
    • Update tests to only include necessary migration steps.
  • File Deletions
    • Delete api_app/db/migrations/airlock.py.
    • Delete api_app/db/migrations/resources.py.
    • Delete api_app/db/migrations/shared_services.py.
    • Delete api_app/db/migrations/workspaces.py.
    • Delete api_app/tests_ma/test_db/test_migrations/test_workspace_migration.py.

For more details, open the Copilot Workspace session.

Fixes #4079

Remove deprecated migration steps from the `migrate_database` function in `api_app/api/routes/migrations.py`.

* **Migration Steps Removal**
  - Remove multiple deprecated migration steps from the `migrate_database` function.
  - Update the `migrate_database` function to only include necessary migration steps.
* **Version Update**
  - Update the version in `api_app/_version.py` from "0.19.3" to "0.20.0".
* **Test Updates**
  - Remove tests related to deprecated migration steps in `api_app/tests_ma/test_api/test_routes/test_migrations.py`.
  - Update tests to only include necessary migration steps.
* **File Deletions**
  - Delete `api_app/db/migrations/airlock.py`.
  - Delete `api_app/db/migrations/resources.py`.
  - Delete `api_app/db/migrations/shared_services.py`.
  - Delete `api_app/db/migrations/workspaces.py`.
  - Delete `api_app/tests_ma/test_db/test_migrations/test_workspace_migration.py`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4079?shareId=XXXX-XXXX-XXXX-XXXX).
@marrobi
Copy link
Member Author

marrobi commented Dec 5, 2024

@tim-allen-ck hopefully this is a start, not tested etc, but please feel free to take this and iterate.

Copy link

github-actions bot commented Dec 5, 2024

Unit Test Results

595 tests   369 ✅  18s ⏱️
  1 suites    0 💤
  1 files      0 ❌  226 🔥

For more details on these errors, see this check.

Results for commit 1426aaf.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old migrations
1 participant