-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to delete a Guacamole User Resource if it is in the 'stopped' state #4135
Comments
Hi @dram1964 sounds like there's a logic error in the code for this, its been added to the backlog to look into a fix |
Think it's worth validating this via the API first, then the UI. It could be the UI has an issue, as I don't think "Delete" which triggers |
The manual workaround would be to delete the resource from cosmos and from Azure, but hope we can find a better solution and fix the issue. |
It's actually a terraform issue: hashicorp/terraform-provider-azurerm#28218 we need to add this to all the Guacamole VM templates: provider "azurerm" {
features {
virtual_machine {
skip_shutdown_and_force_delete = true
}
}
} |
Fixes #4135 Add `skip_shutdown_and_force_delete` configuration to Guacamole VM templates to fix deletion issue. * Modify `main.tf` files in `templates/workspace_services/guacamole/user_resources/guacamole-azure-export-reviewvm/terraform`, `guacamole-azure-import-reviewvm/terraform`, `guacamole-azure-linuxvm/terraform`, and `guacamole-azure-windowsvm/terraform` to include `skip_shutdown_and_force_delete = true` under the `virtual_machine` block in the `features` section. * Update `porter.yaml` files in `templates/workspace_services/guacamole/user_resources/guacamole-azure-export-reviewvm`, `guacamole-azure-import-reviewvm`, `guacamole-azure-windowsvm`, and `guacamole-azure-linuxvm` to increment the version numbers. * Update `CHANGELOG.md` to include the fix for the deletion issue. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4135?shareId=XXXX-XXXX-XXXX-XXXX).
@tamirkamara got any other ideas for this then? |
Deleting a VM from the Guacamole service fails if the VM is in a stopped state
Attempting to delete a 'Stopped' VM, results in a 'deleting_failed' status and displays the following error:
Seems that the deletion request fails because it is trying to stop the VM, when it is already stopped. If I 'Enable' the resource, 'Start' it, then 'Disable' it, the resource can be deleted successfully.
Steps to reproduce
Although I'm currently seeing this error from a Custom Workspace and a Custom Guacamole User-Resource, I did also encounter this problem when using the tre-base-workspace (1.5.7) and the tre-service-guacamole-linuxvm (1.0.3)
Azure TRE release version (e.g. v0.19.1):
Deployed Azure TRE components: tre-service-guacamole (0.10.9), tre-service-guacamole-linuxvm (1.0.3)
The text was updated successfully, but these errors were encountered: