Fix unable to delete Guacamole VM in stopped state #4203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4135 Add `skip_shutdown_and_force_delete` configuration to Guacamole VM templates to fix deletion issue. * Modify `main.tf` files in `templates/workspace_services/guacamole/user_resources/guacamole-azure-export-reviewvm/terraform`, `guacamole-azure-import-reviewvm/terraform`, `guacamole-azure-linuxvm/terraform`, and `guacamole-azure-windowsvm/terraform` to include `skip_shutdown_and_force_delete = true` under the `virtual_machine` block in the `features` section. * Update `porter.yaml` files in `templates/workspace_services/guacamole/user_resources/guacamole-azure-export-reviewvm`, `guacamole-azure-import-reviewvm`, `guacamole-azure-windowsvm`, and `guacamole-azure-linuxvm` to increment the version numbers. * Update `CHANGELOG.md` to include the fix for the deletion issue. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4135?shareId=XXXX-XXXX-XXXX-XXXX).
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 72bc099. |
|
/test-force-approve Not tested |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 72bc099) (in response to this comment from @marrobi) |
tamirkamara
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4135
Add
skip_shutdown_and_force_deleteconfiguration to Guacamole VM templates to fix deletion issue.main.tffiles intemplates/workspace_services/guacamole/user_resources/guacamole-azure-export-reviewvm/terraform,guacamole-azure-import-reviewvm/terraform,guacamole-azure-linuxvm/terraform, andguacamole-azure-windowsvm/terraformto includeskip_shutdown_and_force_delete = trueunder thevirtual_machineblock in thefeaturessection.porter.yamlfiles intemplates/workspace_services/guacamole/user_resources/guacamole-azure-export-reviewvm,guacamole-azure-import-reviewvm,guacamole-azure-windowsvm, andguacamole-azure-linuxvmto increment the version numbers.CHANGELOG.mdto include the fix for the deletion issue.For more details, open the Copilot Workspace session.