Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type safety of internal classes #311

Open
delmyers opened this issue Oct 20, 2020 · 0 comments
Open

Improve type safety of internal classes #311

delmyers opened this issue Oct 20, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@delmyers
Copy link
Contributor

There are a number of places where we cast from a base class to a derived class in our internal code, which could cause problems if a caller passes us an instance of an interface that we did not create internally. I suggest we:

  1. Update our code to use virtual inheritance (instead of multiple inheritance). This will help us catch locations where we cast from a base class.

  2. QI for the derived class. This will give us type safety.

@delmyers delmyers added the bug Something isn't working label Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant