Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TestNl2FxIsCanceledCorrectly deterministic #2755

Open
MikeStall opened this issue Nov 27, 2024 · 0 comments
Open

Make TestNl2FxIsCanceledCorrectly deterministic #2755

MikeStall opened this issue Nov 27, 2024 · 0 comments

Comments

@MikeStall
Copy link
Contributor

This is a flakey test. , failing here https://github.com/microsoft/Power-Fx/pull/2728/checks?check_run_id=33611576122

Anything with something like this CancelAfter(500) ms is going to be flaky.

Power-Fx/src/tests/Microsoft.PowerFx.Interpreter.Tests.Shared/LanguageServiceProtocol/RedesignedLanguageServerTests/CancellationTests.cs

Line 31 in ef55044

source.CancelAfter(500);

Make it deterministic.
@MikeStall MikeStall changed the title Fix TestNl2FxIsCanceledCorrectly Make TestNl2FxIsCanceledCorrectly deterministic Nov 27, 2024
@MikeStall MikeStall mentioned this issue Nov 27, 2024
Merged
MikeStall added a commit that referenced this issue Nov 27, 2024
@MikeStall
Disable flaky test (#2756)
216c29c 
See #2755 

Get a real fix next

Co-authored-by: Mike <[email protected]>
@sourcery-ai sourcery-ai bot mentioned this issue Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MikeStall